Skip to content

Fix issues reported by Go checks#88

Merged
nywilken merged 5 commits intomainfrom
nywilken/fix-failing-go-checks
Sep 9, 2022
Merged

Fix issues reported by Go checks#88
nywilken merged 5 commits intomainfrom
nywilken/fix-failing-go-checks

Conversation

@nywilken
Copy link
Copy Markdown
Contributor

  • Fix go mod tidy check errors
  • Resolve spacing issues to fix goimport errors

@nywilken nywilken requested a review from a team as a code owner August 31, 2022 22:06
@nywilken nywilken force-pushed the nywilken/fix-failing-go-checks branch from ee9f43a to f4bf666 Compare August 31, 2022 22:08
The staticcheck error report SA4005: ineffective assignment to field
NetworkMapperMock.NameIntoDeviceCalled was valid, as modifying these
values would do nothing on the receiver. Converting to a pointer allows
for the call to modify the structures data for proper validation.
* S1038: should use t.Errorf(...) instead of t.Error(fmt.Sprintf(...))
* SA4001: *&x will be simplified to x. It will not copy x.
* File is not `goimports`-ed (goimports)
@nywilken nywilken requested a review from sylviamoss August 31, 2022 22:50
@nywilken nywilken merged commit 02e7be0 into main Sep 9, 2022
@nywilken nywilken deleted the nywilken/fix-failing-go-checks branch September 9, 2022 17:20
@tenthirtyam tenthirtyam added this to the v1.0.8 milestone Dec 4, 2022
@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants