Merged
Conversation
Contributor
nywilken
commented
Aug 31, 2022
- Fix go mod tidy check errors
- Resolve spacing issues to fix goimport errors
ee9f43a to
f4bf666
Compare
The staticcheck error report SA4005: ineffective assignment to field NetworkMapperMock.NameIntoDeviceCalled was valid, as modifying these values would do nothing on the receiver. Converting to a pointer allows for the call to modify the structures data for proper validation.
* S1038: should use t.Errorf(...) instead of t.Error(fmt.Sprintf(...)) * SA4001: *&x will be simplified to x. It will not copy x. * File is not `goimports`-ed (goimports)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.