Skip to content

Ensure the contents of floppy_content gets added to the configured floppy device#80

Merged
nywilken merged 1 commit intovmware:mainfrom
tenthirtyam:fix/gh-77
Jul 27, 2022
Merged

Ensure the contents of floppy_content gets added to the configured floppy device#80
nywilken merged 1 commit intovmware:mainfrom
tenthirtyam:fix/gh-77

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Add Content to StepCreateFloppy to allow content to be added to floppy device.

Closes #77

Add `Content` to `StepCreateFloppy`

#77

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 7, 2022 16:30
@nywilken nywilken added the bug Bug label Jul 27, 2022
@nywilken nywilken changed the title fix:gh-77 Add missing configuration to allow content to be added to a floppy device via floppy_content Jul 27, 2022
@nywilken nywilken changed the title Add missing configuration to allow content to be added to a floppy device via floppy_content Ensure the contents of floppy_content gets added to the configured floppy device Jul 27, 2022
Copy link
Copy Markdown
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@nywilken nywilken merged commit 0abd482 into vmware:main Jul 27, 2022
@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

Thanks for the review and merge, @nywilken!

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

@tenthirtyam tenthirtyam deleted the fix/gh-77 branch August 12, 2022 22:56
@tenthirtyam tenthirtyam added this to the v1.0.8 milestone Dec 4, 2022
@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

floppy_content not working on vmware builders

2 participants