Skip to content

refactor: add support for bridged networking#462

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/bridged-networking
Mar 2, 2026
Merged

refactor: add support for bridged networking#462
tenthirtyam merged 1 commit intomainfrom
refactor/bridged-networking

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Feb 28, 2026

Summary

Refactors to add support bridged networking.

  • Adds the ability to retrieve the IP address of the guest operating system from VMware Tools.
  • Detects the IP address of the host to use based on the default route of the bridged interface.
  • Uses the IP address of the guest operating system received from VMware Tools when using bridged networking.
  • Uses the IP address of the guest operating system received from VMware Tools as a fallback for NAT and host-only networking.

Note: The method for NAT and host-only networking may be subsequently refactored to only use the VMware Tools method, but this commit limits the scope to only adding support for bridged networking.

Type

  • fix: Bug Fix
  • feat: Feature or Enhancement
  • docs: Documentation
  • refactor: Refactoring
  • chore: Build, Dependencies, Workflows, etc.
  • other: Other (Please describe.)

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Tests

  • Tests have been added or updated.
  • Tests have been completed.

Output:

Documentation

  • Documentation has been added or updated.

Issue References

Resolves #397

Release Note

Additional Information

@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Feb 28, 2026
@tenthirtyam tenthirtyam self-assigned this Feb 28, 2026
@tenthirtyam tenthirtyam added the refactor Refactor label Feb 28, 2026
@github-actions github-actions bot added needs-review Needs Review size/l Relative Sizing: Large labels Feb 28, 2026
@tenthirtyam tenthirtyam force-pushed the refactor/bridged-networking branch from 8ada1f5 to 43ada88 Compare February 28, 2026 20:32
@tenthirtyam tenthirtyam marked this pull request as ready for review February 28, 2026 20:34
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 28, 2026 20:34
Copilot AI review requested due to automatic review settings February 28, 2026 20:34

This comment was marked as resolved.

@tenthirtyam tenthirtyam marked this pull request as draft February 28, 2026 20:47
@tenthirtyam tenthirtyam force-pushed the refactor/bridged-networking branch 5 times, most recently from 0aab2c5 to 5882df1 Compare March 1, 2026 23:52
@github-actions github-actions bot added the documentation Documentation label Mar 1, 2026
@tenthirtyam tenthirtyam force-pushed the refactor/bridged-networking branch 3 times, most recently from 922973c to 8c0046c Compare March 2, 2026 11:40
Refactors to add support bridged networking.

- Adds the ability to retrieve the IP address of the guest operating system from VMware Tools.
- Detects the IP address of the host to use when using bridged networking.
- Uses the IP address of the guest operating system received from VMware Tools when using bridged networking.
- Uses the IP address of the guest operating system received from VMware Tools as a fallback for NAT and host-only networking.

Note: The method for NAT and host-only networking may be subsequently refactored to only use the VMware Tools method, but this commit limits the scope to only adding support for bridged networking.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the refactor/bridged-networking branch from 8c0046c to 6919ac1 Compare March 2, 2026 17:41
@github-actions github-actions bot added the size/xl Relative Sizing: Extra-Large label Mar 2, 2026
@tenthirtyam tenthirtyam marked this pull request as ready for review March 2, 2026 17:56
@tenthirtyam tenthirtyam merged commit 50c60ca into main Mar 2, 2026
10 checks passed
@tenthirtyam tenthirtyam deleted the refactor/bridged-networking branch March 2, 2026 17:59
@tenthirtyam tenthirtyam removed needs-review Needs Review size/l Relative Sizing: Large labels Mar 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2026

This functionality has been released in v2.1.0 of the plugin.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Documentation refactor Refactor size/xl Relative Sizing: Extra-Large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bridged Networking Error: error detecting host IP: unable to find vmnetdhcp conf file

2 participants