Conversation
Post-transfer removal of artifact headers. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR removes HashiCorp copyright and SPDX license headers from two YAML configuration files (.goreleaser.yml and .golangci.yml) following a repository transfer from HashiCorp to Broadcom. The PR description indicates this is part of "post-transfer removal of artifact headers."
Changes:
- Removed SPDX-License-Identifier header from .goreleaser.yml
- Removed Copyright and SPDX-License-Identifier headers from .golangci.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .goreleaser.yml | Replaced SPDX license header with YAML document marker --- |
| .golangci.yml | Removed 3 lines of copyright and SPDX license headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,4 +1,4 @@ | |||
| # SPDX-License-Identifier: MPL-2.0 | |||
| --- | |||
There was a problem hiding this comment.
This PR removes HashiCorp copyright and SPDX license headers from only two files (.goreleaser.yml and .golangci.yml), but leaves similar headers in many other files throughout the repository:
- GitHub workflow files: .github/workflows/build_plugin_binaries.yml, .github/workflows/go-validate.yml, .github/workflows/release.yml
- GitHub action files: .github/actions/build-and-persist-plugin-binary/action.yml
- GitHub config: .github/release.yml
- All Go source files in builder/, main.go, version/version.go
This creates an inconsistent state where some files have the old HashiCorp headers while others don't. For a post-transfer cleanup, consider either:
- Removing headers from all files consistently, or
- Keeping a consistent header approach across the entire codebase
The selective removal in just these two files appears incomplete for the stated purpose of "post-transfer removal of artifact headers."
|
This functionality has been released in v2.0.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
1 similar comment
|
This functionality has been released in v2.0.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
Post-transfer removal of artifact headers.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Additional Information