Conversation
Post-transfer update of issue config. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub issue template configuration file as part of a repository transfer from HashiCorp to VMware. The changes reflect the new organizational ownership and update community resource links.
Changes:
- Removed HashiCorp copyright header and added YAML front matter separator
- Updated community discussions URL from HashiCorp forum to VMware GitHub discussions
- Updated plugin documentation URL to reflect new namespace structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| about: Need some help? Join the community discussions. | ||
| - name: Packer Plugin Documentation | ||
| url: https://developer.hashicorp.com/packer/integrations/hashicorp/vmware | ||
| url: https://developer.hashicorp.com/packer/integrations/vmware/vmware |
There was a problem hiding this comment.
The plugin documentation URL has been changed from https://developer.hashicorp.com/packer/integrations/hashicorp/vmware to https://developer.hashicorp.com/packer/integrations/vmware/vmware. However, there are inconsistencies across the codebase:
- Documentation files (
.web-docs/README.md:17anddocs/README.md:17) still reference the plugin source asgithub.com/hashicorp/vmware - Workflow files still use the integration identifier
packer/hashicorp/vmware(see.github/workflows/notify-integration-release-via-manual.yaml:59and.github/workflows/notify-integration-release-via-tag.yaml:52)
This URL change should be verified to ensure it correctly reflects:
- Whether the plugin has been fully migrated to a new namespace on the Packer registry
- Whether the old URL redirects to the new one, or if users will encounter 404 errors
- Whether all related references in documentation and workflows need to be updated together
Consider verifying the correct URL structure for the new plugin location and ensuring consistency across all files that reference the plugin's location or documentation.
| contact_links: | ||
| - name: Community Discussions | ||
| url: https://discuss.hashicorp.com/c/packer/23 | ||
| url: https://github.com/vmware/packer-plugin-vmware/discussions |
There was a problem hiding this comment.
There is an inconsistency in the handling of the old HashiCorp community discussions URL. This file updates the discussions URL from https://discuss.hashicorp.com/c/packer/23 to https://github.com/vmware/packer-plugin-vmware/discussions, which correctly reflects the repository transfer.
However, .github/ISSUE_TEMPLATE/question.md:13 still references the old HashiCorp forum: https://discuss.hashicorp.com/c/packer. For consistency with this post-transfer update, consider reviewing whether that reference should also be updated to point to the new VMware repository discussions.
| # Copyright (c) HashiCorp, Inc. | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
|
|
||
| --- |
There was a problem hiding this comment.
The copyright and SPDX-License-Identifier header has been removed from this file, but similar configuration files in the repository still retain the header. For example, .github/release.yml (lines 1-2) still contains:
# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0
For consistency with the rest of the codebase and given the repository transfer, consider either:
- Updating this file to use the Broadcom copyright format seen in other files (e.g.,
main.go:1-3), or - Removing copyright headers from other similar configuration files in
.github/to maintain consistency.
Note that the YAML front matter separator (---) is appropriate for GitHub issue template config files, so that change is correct.
|
This functionality has been released in v2.0.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
1 similar comment
|
This functionality has been released in v2.0.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Post-transfer update of issue config.