Conversation
- Updated GitHub Actions workflows for macOS, Linux, and Windows to improve naming consistency, add step names, and clarify comments. - Removed license headers and standardized formatting for better readability and maintainability. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors three GitHub Actions workflow files for Go testing across different platforms (macOS, Linux, and Windows) to improve consistency, readability, and maintainability. The changes remove license headers, standardize formatting with YAML document markers, update naming conventions, and add descriptive step names to previously unnamed action uses.
Changes:
- Removed license headers and added YAML document markers (
---) to all three workflow files - Updated workflow names to use consistent capitalization without quotes (e.g.,
"Go Test Windows"→Go Test Windows) - Added descriptive step names to previously unnamed
usesactions ("Checkout Repository", "Get Go Version", "Setup Go") - Standardized job names to use title case (e.g.,
Windows Go tests→Windows Go Tests) - Removed unnecessary quotes from branch names and simplified comment formatting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/go-test-windows.yml |
Standardized formatting, removed license headers, added step names for checkout and setup-go actions, updated naming to "Windows Go Tests" |
.github/workflows/go-test-linux.yml |
Standardized formatting, removed license headers, added step names for checkout and setup-go actions, updated naming to "Linux Go Tests" |
.github/workflows/go-test-darwin.yml |
Standardized formatting, removed license headers, added step names for checkout and setup-go actions, updated workflow name to "Go Test macOS" while keeping job name as "Darwin Go Tests" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - get-go-version | ||
| runs-on: macos-latest | ||
| name: Darwin Go tests | ||
| name: Darwin Go Tests |
There was a problem hiding this comment.
Inconsistent naming: The workflow is named "Go Test macOS" but the job is named "Darwin Go Tests". For consistency, consider naming the job "macOS Go Tests" to match the workflow name, or vice versa. The other workflows (Linux and Windows) have consistent naming between their workflow and job names.
| name: Darwin Go Tests | |
| name: macOS Go Tests |
|
This functionality has been released in v2.0.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
1 similar comment
|
This functionality has been released in v2.0.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description