Fixed documentation of vmx_data_post#400
Closed
Foo-Manroot wants to merge 1 commit intovmware:mainfrom
Closed
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Collaborator
|
Addressed in #401 since the documentation is generated from the codebase. |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I ommited the whole creating-a-brunch thingy because it's literally three words that need to be changed in a Markdown file...)
Description
Not really a code change, it's a fix in the documentation.
The current documentation (see https://developer.hashicorp.com/packer/integrations/hashicorp/vmware/latest/components/builder/iso#advanced-configuration ) states:
I was looking for a way to change the network adapter from NAT to Host-Only after my VM finished the whole provisioning. I knew I've done something similar recently with Parallels (where they have the
prlctl_post, which is "run after the virtual machine is shutdown, and before the virtual machine is exported", which is why I found strange that thisvmx_data_postwas run after the machine was started (??)Anyways, I tried this setting
and, alas, the config was changed after all my provisioning was finished.
So, the documentation of that parameter is wrong, hence my PR.
For what is worth, the
vmx_data_postparameter is mentioned in another infobox (see the note down in the https://developer.hashicorp.com/packer/integrations/hashicorp/vmware/latest/components/builder/iso#boot-configuration section), where it is correctly documented:For consistency, I just copied that sentence over to the wrong sections.
Resolved Issues
(N/A)
Rollback Plan
(N/A)
Changes to Security Controls
(N/A)