Conversation
Refactors the `usb_version` to account for USB 3.2 in VMware Fusion and Workstation 25H2 - though it's the exact same resulting configuration as 3.1. Signed-off-by: Ryan Johnson <rya@tenthirtyam.org>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for USB 3.2 in VMware Fusion and Workstation 25H2 while maintaining backward compatibility. The change recognizes that USB 3.2 produces identical configuration to USB 3.1 but allows users to specify the newer version.
- Updates default USB version from 2.0 to 3.1 across the codebase
- Adds USB 3.2 as a valid option alongside existing 2.0 and 3.1 versions
- Updates documentation to reflect the new default and available options
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs-partials/builder/vmware/common/HWConfig-not-required.mdx | Updates documentation for USB version configuration |
| builder/vmware/iso/step_create_vmx_test.go | Adds test coverage for USB 3.2 and renames USB 3.1 test |
| builder/vmware/iso/step_create_vmx.go | Updates VMX template to handle USB 3.2 configuration |
| builder/vmware/common/hw_config_test.go | Updates tests to reflect new default and adds USB 3.2 test |
| builder/vmware/common/hw_config.go | Changes default USB version and updates documentation |
| builder/vmware/common/driver.go | Adds USB 3.2 constant and includes it in allowed versions |
| .web-docs/components/builder/iso/README.md | Updates web documentation for USB version options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Refactors the
usb_versionto account for USB 3.2 in VMware Fusion and Workstation 25H2 - though it's the exact same resulting configuration as 3.1.Resolved Issues
Closes #391
Rollback Plan
Revert commit.
Changes to Security Controls
None.