docs: Add instructions for VMware Player on Linux by sbrownjc · Pull Request #39 · vmware/packer-plugin-vmware

sbrownjc · 2021-09-20T20:15:44Z

In attempting to get packer working with VMWare Workstation Player on Linux, I had a lot of trouble until I found the information scattered about the internet, and then found this closed PR, whose instructions mirrored exactly what I'd done to get Workstation Player 16 running with Packer: hashicorp/packer#3451

This closed issue hashicorp/packer#1102 references this (lost?) commit: hashicorp/packer@c5ec92c which would have saved me much time if I could have seen it, so I'm making this PR to bring the information from hashicorp/packer#3451 in and up-to-date.

hashicorp-cla · 2021-09-20T20:15:47Z

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

nywilken · 2022-07-27T17:56:59Z

👋 I still think that this comment is still very relevant. That said, @tenthirtyam do you have some thoughts on how we should be capture this.

Is this something that you have documented within your vmware-samples repo?

tenthirtyam · 2022-07-27T18:09:58Z

Hey, @nywilken -

I don't have anything in that project that uses the vmware-iso builder - it uses the vsphere-iso builder.

I do use the vmware-iso builder for VMware Fusion and VMware Workstation in the https://github.com/vmware/photon-packer-templates project to create Photon images for Vagrant. However, VMware Player is not included/tested.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam · 2022-07-27T18:17:30Z

I've added some comments to this PR for context, clarity, and correctness.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam

@nywilken @sbrownjc, I've recommended some changes before merge.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam · 2022-07-27T18:12:25Z

docs/builders/index.mdx

+Additionally you will need to have the `vmrun` command, which is part of the
+VMware [Virtual Infrastructure eXtension][vix-api] [(VIX) SDK][vix-sdk].
+
+Finally, if you installed a version of VMware player newer than 7.0, you must


"VMware Workstation Player"

tenthirtyam · 2022-07-27T18:12:35Z

docs/builders/index.mdx

+## VMware (Workstation) Player on Linux
+
+Unfortunately just installing VMware Player is not quite enough to be able to
+use packer. You will also need the `qemu-img` command which is available in


tenthirtyam · 2022-07-27T18:14:05Z

docs/builders/index.mdx

+
+Unfortunately just installing VMware Player is not quite enough to be able to
+use packer. You will also need the `qemu-img` command which is available in
+the `qemu` package on Debian- and Fedora-like systems.


I would use "Red Hat Enterprise Linux and derivative" as well and "Debian and derivative".

tenthirtyam · 2022-07-27T18:15:01Z

docs/builders/index.mdx

+
+## VMware (Workstation) Player on Linux
+
+Unfortunately just installing VMware Player is not quite enough to be able to


Remove "Unfortunately just..."

tenthirtyam · 2022-07-27T18:15:26Z

docs/builders/index.mdx

+
+Finally, if you installed a version of VMware player newer than 7.0, you must
+edit the file `/usr/lib/vmware-vix/vixwrapper-config.txt` and change the
+version specified in the fourth column there to be the version in the third


Remove "there".

tenthirtyam · 2022-07-27T18:16:09Z

docs/builders/index.mdx

+Finally, if you installed a version of VMware player newer than 7.0, you must
+edit the file `/usr/lib/vmware-vix/vixwrapper-config.txt` and change the
+version specified in the fourth column there to be the version in the third
+column of the `vmplayer -v` command. See [this thread][so] for more details.


"this StackOverflow thread"

tenthirtyam · 2022-08-09T01:13:35Z

docs/builders/index.mdx

  benefit, you can feed the artifact of this builder back into Packer to
  iterate on a machine.
+
+## VMware (Workstation) Player on Linux


"VMware Workstation Player on Linux"

tenthirtyam · 2022-08-09T01:14:33Z

docs/builders/index.mdx

+
+## VMware (Workstation) Player on Linux
+
+Unfortunately just installing VMware Player is not quite enough to be able to


"VMware Workstation Player"

tenthirtyam · 2022-08-09T01:16:08Z

docs/builders/index.mdx

+Additionally you will need to have the `vmrun` command, which is part of the
+VMware [Virtual Infrastructure eXtension][vix-api] [(VIX) SDK][vix-sdk].
+
+Finally, if you installed a version of VMware player newer than 7.0, you must


I would remove the versioning. Ideally the plugin should support only those versions supported by VMware per the lifecycle matrix. See project README.

sbrownjc · 2022-08-10T21:53:09Z

@tenthirtyam Thanks for the review comments, I've updated the docs accordingly.

tenthirtyam · 2022-08-11T00:45:09Z

Thanks! I'll review the updates tomorrow for Wilken and provide and update.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam

LGTM! 🚀

cc @nywilken

nywilken · 2022-08-12T17:20:52Z

@tenthirtyam thanks for the thoughts and review on this PR, and @sbrownjc thanks for updates. The changes look good me me. We just need to have you sign the CLA so that I can merge these changes in.

If you have already accepted the CLA please make sure that the email used in your commits match the email you signed the CLA with and that the signing email is your primary GitHub email. The CLA bot only checks against the user's primary GitHub email.

tenthirtyam · 2022-09-28T03:52:06Z

Hi @sbrownjc - could you resolve the issue with signing the HashiCorp CLA? This will help expedite your valuable updates.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

tenthirtyam · 2022-10-07T03:58:06Z

Hi @sbrownjc - could you resolve the issue with signing the HashiCorp CLA? This will help expedite your valuable updates.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

sbrownjc · 2022-10-17T18:23:41Z

Hi @tenthirtyam, I'm sorry for the delay, I was waiting on a response from legal since I posted using my work GH account.

If possible, I would like to submit this work outside of a CLA, following section 7 of the CLA:

Should You wish to submit work that is not Your original creation, You may submit it to HashiCorp separately from any Contribution, identifying the complete details of its source and of any license or other restriction (including, but not limited to, related patents, trademarks, and license agreements) of which you are personally aware, and conspicuously marking the work as "Submitted on behalf of a third-party: [named here]".

This work is being Submitted on behalf of a third-party: Anand Kumria, the complete details of the source are in the original post.

tenthirtyam · 2022-10-17T23:28:02Z

cc @nywilken for submission state review.

nywilken · 2023-01-30T17:14:34Z

@sbrownjc @tenthirtyam apologies for not getting back much sooner. In speaking with our legal team the author of the change must still sign the CLA in order to make the contribution on behalf of another contributor under section 7. Unfortunately that means I will not be able to merge in these changes unless the CLA is signed.

I'm going to close this PR given the time I kept everyone waiting. If you wish to reopen with your personal GH and sign the CLA I would be glad to merge it right away.

Thank you @tenthirtyam for your help here.

Add instructions to get VMWare Player working on Linux

185930e

sbrownjc requested a review from a team as a code owner September 20, 2021 20:15

nywilken added the wontfix label Jul 27, 2022

tenthirtyam requested changes Aug 9, 2022

View reviewed changes

Merge branch 'main' into vmware-player-on-linux

41ebd55

tenthirtyam approved these changes Aug 11, 2022

View reviewed changes

nywilken added docs and removed wontfix labels Aug 12, 2022

tenthirtyam added the stage/awaiting-reply Stage: Awaiting Reply label Sep 28, 2022

tenthirtyam assigned sbrownjc Sep 28, 2022

tenthirtyam changed the title ~~Add instructions to get VMWare Player working on Linux~~ docs: add instructions for VMware Player on Linux Sep 28, 2022

tenthirtyam changed the title ~~docs: add instructions for VMware Player on Linux~~ docs: Add instructions for VMware Player on Linux Sep 28, 2022

tenthirtyam requested a review from nywilken November 22, 2022 04:55

tenthirtyam added this to the v1.0.8 milestone Dec 4, 2022

nywilken closed this Jan 30, 2023

nywilken added needs-cla and removed stage/awaiting-reply Stage: Awaiting Reply labels Jan 30, 2023

StephenBrown2 mentioned this pull request Apr 4, 2023

docs: Add instructions for VMware Player on Linux #128

Merged

vmware locked and limited conversation to collaborators Jun 29, 2024

tenthirtyam added documentation Documentation and removed docs labels Jul 10, 2024


		## VMware (Workstation) Player on Linux

		Unfortunately just installing VMware Player is not quite enough to be able to

Conversation

sbrownjc commented Sep 20, 2021

Uh oh!

hashicorp-cla commented Sep 20, 2021

Uh oh!

nywilken commented Jul 27, 2022

Uh oh!

tenthirtyam commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tenthirtyam commented Jul 27, 2022

Uh oh!

tenthirtyam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbrownjc commented Aug 10, 2022

Uh oh!

tenthirtyam commented Aug 11, 2022

Uh oh!

tenthirtyam left a comment

Choose a reason for hiding this comment

Uh oh!

nywilken commented Aug 12, 2022

Uh oh!

tenthirtyam commented Sep 28, 2022

Uh oh!

tenthirtyam commented Oct 7, 2022

Uh oh!

sbrownjc commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tenthirtyam commented Oct 17, 2022

Uh oh!

nywilken commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tenthirtyam commented Jul 27, 2022 •

edited

Loading

sbrownjc commented Oct 17, 2022 •

edited

Loading