Merged
Conversation
6777bbc to
9590983
Compare
cf0eb4e to
2e482b2
Compare
2e482b2 to
394d756
Compare
usb_version with usb
7777b63 to
53a9931
Compare
usb_version with usbusb_version with usb
BREAKING CHANGE: `usb_version` field is required when `usb` is enabled" - Adds `usb_version` string field with values "2.0" or "3.1" - Requires explicit `usb_version `when `usb = true` - Adds error handling for requiring both fields. - Automatically enables USB and uses version 2.0 on Apple Silicon-based hypervisors. Signed-off-by: Ryan Johnson <rya@tenthirtyam.org>
53a9931 to
3fa2e31
Compare
kp2099
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Caution
This is a breaking change and will be shipped in v2.
Introduces support for configurable USB controller versions in virtual machine builds, with improved handling for Apple Silicon systems. The changes allow users to specify the USB version ("2.0" or "3.1") via a new
usb_versionoption, and ensure automatic USB configuration for plugin compatibility on Apple Silicon. Extensive validation and tests have been added to ensure correct behavior across platforms.USB Controller Configuration Enhancements:
usb_versionoption to allow selection between USB 2.0 and USB 3.1 controllers when USB is enabled, with validation for allowed values. [1] [2] [3] [4]darwin/arm64): USB is automatically enabled and set to version 2.0 if not explicitly configured, ensuring plugin functionality. [1] [2]VMX Template and Build Logic:
usbandusb_versionvalues, supporting both USB 2.0 and 3.1. [1] [2] [3]Validation and Testing:
Documentation Updates:
.web-docs/components/builder/iso/README.mdanddocs-partials/builder/vmware/common/HWConfig-not-required.mdx. [1] [2]Example and Cleanup:
Resolved Issues
vmx_data.arm64.Rollback Plan
Revert commit.
Changes to Security Controls
None.