Skip to content

fix: attach custom cd for cd_files#375

Merged
JenGoldstrich merged 1 commit intomainfrom
fix/attach-custom-cd-for-cdfiles
Aug 28, 2025
Merged

fix: attach custom cd for cd_files#375
JenGoldstrich merged 1 commit intomainfrom
fix/attach-custom-cd-for-cdfiles

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Aug 27, 2025

Description

Fixes the issue attaching a custom CD when cd_files is used.

Closes #15
Closes #182

Fixes the issue attaching a custom CD when `cd_files` is used.

Ref: #15

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Aug 27, 2025
@tenthirtyam tenthirtyam self-assigned this Aug 27, 2025
@tenthirtyam tenthirtyam added the bug Bug label Aug 27, 2025
@tenthirtyam tenthirtyam marked this pull request as ready for review August 27, 2025 02:39
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 27, 2025 02:39
Copy link
Copy Markdown

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! seems like the issue has been around for a while

@JenGoldstrich JenGoldstrich merged commit e9dbb12 into main Aug 28, 2025
14 checks passed
@JenGoldstrich JenGoldstrich deleted the fix/attach-custom-cd-for-cdfiles branch August 28, 2025 00:19
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vmware-vmx: cd_files, cd_content not working for ARM guests vmware-iso: cd_files not working properly

2 participants