Conversation
1eb22a6 to
7efa6db
Compare
9ceb886 to
fb63642
Compare
46f0b3d to
be5e16c
Compare
394acca to
9ce0a6f
Compare
a28903d to
df78c0e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for cloning virtual machines from .ovf and .ova files using ovftool, in addition to the existing .vmx file support. The changes also reorganize the examples directory and add comprehensive examples for the vmware-vmx builder.
- Add .ovf/.ova cloning capability using ovftool with new configuration parameters
- Reorganize examples into separate iso/ and vmx/ directories with platform-specific configurations
- Update documentation to reflect the new cloning capabilities
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
builder/vmware/vmx/step_clone_vmx.go |
Core implementation of .ovf/.ova cloning using ovftool |
builder/vmware/vmx/config.go |
Added guest_os_type and version configuration parameters with validation |
builder/vmware/vmx/config.hcl2spec.go |
Generated HCL2 specification for new configuration fields |
builder/vmware/vmx/builder.go |
Integration of new parameters into the build process |
example/vmx/ |
New vmware-vmx examples with support for .vmx, .ovf, and .ova sources |
example/iso/ |
Reorganized vmware-iso examples with updated variable structure |
docs-partials/ |
Updated documentation to reflect new source file support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
df78c0e to
723031d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
723031d to
66c7f83
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Add support for cloning virtual machines from .ovf and .ova files using ovftool, in addition to .vmx files. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
66c7f83 to
3f5dc81
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 30 out of 31 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for cloning virtual machines from .ovf and .ova files using ovftool, in addition to .vmx files.
Also reorganizes the examples and includes examples for
vmware-vmxwhich include the capabilities added in this pull request.Resolved Issues
Closes #9
Rollback Plan
Revert commit.
Changes to Security Controls
None.