Conversation
bca40b1 to
26658cd
Compare
772dcd5 to
dd24663
Compare
dd24663 to
f4390a6
Compare
f4390a6 to
d03c522
Compare
Adds `StepAttachAdditionalDisks` to the `vmware-vmx` builder, enabling attachment of additional disks. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
d03c522 to
9fd25d0
Compare
| ui := state.Get("ui").(packersdk.Ui) | ||
| vmxPath := state.Get("vmx_path").(string) | ||
|
|
||
| if len(config.AdditionalDiskSize) == 0 { |
There was a problem hiding this comment.
I feel like there's two patterns here for skipping steps often, either adding a check into the step at the top level, like you do here, or in the builder only adding the step if its necessary. I tend to prefer having that complexity live in the builder, and having simpler steps. This is a balancing act though as you can end up with a builder with too many concerns: https://github.com/hashicorp/packer-plugin-azure/blob/main/builder/azure/arm/builder.go like the Azure ARM builder.
I wouldn't change this here, but I would just be aware of these trade-offs, and make a consistent choice
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adds
StepAttachAdditionalDisksto thevmware-vmxbuilder, enabling attachment of additional disks.Testing:
Notice the following:
Which in the
.vmxlooks like:And...
Acceptance Test:
TestRun_AttachAdditional Disks_SkipsReservedUnit7Resolved Issues
Closes #119
Rollback Plan
Revert commit.
Changes to Security Controls
None.