Skip to content

chore: update virtual hardware versions#370

Merged
JenGoldstrich merged 1 commit intomainfrom
chore/update-virtual-hardware-versions
Aug 28, 2025
Merged

chore: update virtual hardware versions#370
JenGoldstrich merged 1 commit intomainfrom
chore/update-virtual-hardware-versions

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Aug 19, 2025

Description

Updated the minimum supported hardware version from 13 to 19 and the default from 19 to 21 in the vmware-iso builder.

Reference: https://knowledge.broadcom.com/external/article/315655/virtual-machine-hardware-versions.html

  • Increased the minimum supported hardware version from 13 to 19 and the default hardware version from 19 to 21 in the Config struct documentation in builder/vmware/iso/config.go.
  • Updated the constants MinimumHardwareVersion and DefaultHardwareVersion in builder/vmware/common/driver.go to match the new requirements.

Documentation consistency:

  • Updated the hardware version information in docs-partials/builder/vmware/iso/Config-not-required.mdx for consistency with the code changes.

Resolved Issues

Ensure consistency and reflect supported versions in #369.

Rollback Plan

Revert commit.

Changes to Security Controls

None.

@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Aug 19, 2025
@tenthirtyam tenthirtyam self-assigned this Aug 19, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 19, 2025 18:38
@tenthirtyam tenthirtyam added refactor Refactor version/bump major Version: Bump Major labels Aug 19, 2025
@tenthirtyam tenthirtyam added chore Chore and removed refactor Refactor labels Aug 19, 2025
@tenthirtyam tenthirtyam marked this pull request as draft August 19, 2025 18:41
@tenthirtyam tenthirtyam changed the title chore: update virtual hardware versions [wip] chore: update virtual hardware versions Aug 19, 2025
@tenthirtyam tenthirtyam force-pushed the chore/update-virtual-hardware-versions branch from da6e0c3 to 614dc2e Compare August 20, 2025 11:59
@tenthirtyam tenthirtyam force-pushed the chore/update-virtual-hardware-versions branch from 614dc2e to 4ec1198 Compare August 28, 2025 02:22
Updated the minimum supported hardware version from 13 to 19 and the default from 19 to 21 in the `vmware-iso` builder.

Reference: https://knowledge.broadcom.com/external/article/315655/virtual-machine-hardware-versions.html

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore/update-virtual-hardware-versions branch from 4ec1198 to 4c50f1c Compare August 28, 2025 16:49
@tenthirtyam tenthirtyam changed the title [wip] chore: update virtual hardware versions chore: update virtual hardware versions Aug 28, 2025
@tenthirtyam tenthirtyam marked this pull request as ready for review August 28, 2025 16:55
@JenGoldstrich JenGoldstrich merged commit d4f7c8e into main Aug 28, 2025
14 checks passed
@JenGoldstrich JenGoldstrich deleted the chore/update-virtual-hardware-versions branch August 28, 2025 22:37
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore version/bump major Version: Bump Major

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants