Merged
Conversation
Updated log messages across components to consistently use [INFO] and [WARN] prefixes and improved error descriptions for clarity. This change enhances log readability and makes error handling more uniform throughout the codebase. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
JenGoldstrich
approved these changes
Aug 15, 2025
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardizes and improves the clarity of log messages throughout the VMware builder codebase by updating the phrasing of log outputs and consistently adding log level prefixes (such as
[INFO]and[WARN]). This helps make log output more uniform and easier to interpret, which is beneficial for both debugging and monitoring. Additionally, several test assertions have been updated to use clearer error messages.[INFO]and[WARN]prefixes to log messages indriver.go,driver_esxi.go,driver_workstation_windows.go,step_configure_vnc.go,step_output_dir.go, andstep_remote_upload.go, ensuring consistent log levels and improved readability. [1] [2] [3] [4] [5] [6]driver_parser_test.goandhw_config_test.go. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]These changes collectively make the codebase's logging and error reporting more consistent and easier to understand for future maintenance and debugging.
Rollback Plan
Revert commit.
Changes to Security Controls
None.