Skip to content

chore: remove esx support#336

Merged
kp2099 merged 1 commit intomainfrom
chore/remove-esx-support
Aug 28, 2025
Merged

chore: remove esx support#336
kp2099 merged 1 commit intomainfrom
chore/remove-esx-support

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Aug 8, 2025 •
edited
Loading

Description

Warning

Support for VMware ESX is removed in this pull request.

This is a breaking change and requires a major version release.

Removes support for VMware ESX.

Testing using legacy support for remote_type for VMware ESX:

packer-plugin-vmware/example on  chore/remove-esx-support via 🐹 v1.25.0 
➜ packer build -var-file=pkrvars/debian/fusion-13.pkrvars.hcl .
Error: 1 error(s) occurred:

* 'remote_type': VMware ESX is not supported by the plugin as of v2.0.0. Please use the Packer plugin for VMware vSphere.

  on sources.pkr.hcl line 9:
  (source code not available)

Testing with VMware Fusion (Apple Silicon):

packer-plugin-vmware/example on  chore/remove-esx-support [!?] via 🐹 v1.25.0 took 2.4s 
➜ packer build -var-file=pkrvars/debian/fusion-13.pkrvars.hcl .
vmware-iso.debian: output will be in this color.

==> vmware-iso.debian: Retrieving ISO
==> vmware-iso.debian: Trying https://cdimage.debian.org/cdimage/archive/11.7.0/arm64/iso-dvd/debian-11.7.0-arm64-DVD-1.iso
==> vmware-iso.debian: Trying https://cdimage.debian.org/cdimage/archive/11.7.0/arm64/iso-dvd/debian-11.7.0-arm64-DVD-1.iso?checksum=sha256%3A3b0d304379b671d7b7091631765f87e1cbb96b9f03f8e9a595a2bf540c789f3f
==> vmware-iso.debian: https://cdimage.debian.org/cdimage/archive/11.7.0/arm64/iso-dvd/debian-11.7.0-arm64-DVD-1.iso?checksum=sha256%3A3b0d304379b671d7b7091631765f87e1cbb96b9f03f8e9a595a2bf540c789f3f => /Users/ryan.johnson/.cache/packer/9f48ff8a8480e246130c081c066ce94b64069a1e.iso
==> vmware-iso.debian: Configuring output and export directories...
==> vmware-iso.debian: Creating temporary RSA SSH key for instance...
==> vmware-iso.debian: Creating virtual machine disks...
==> vmware-iso.debian: Generating the .vmx file...
==> vmware-iso.debian: Starting HTTP server on port 8424
==> vmware-iso.debian: Powering on virtual machine...
==> vmware-iso.debian: The virtual machine will be run headless, without a GUI.
==> vmware-iso.debian: To view the virtual machine console, connect using VNC:                                                                                                                                                                                                                                                                                                                                                              
==> vmware-iso.debian:                                                                                                                                                                                                                                                                                                                                                                                                                      
==> vmware-iso.debian: Endpoint: "vnc://127.0.0.1:5962"                                                                                                                                                                                                                                                                                                                                                                                     
==> vmware-iso.debian: Password: "rc6GwUyS"                                                                                                                                                                                                                                                                                                                                                                                                 
==> vmware-iso.debian: Connecting to VNC...
==> vmware-iso.debian: Waiting 10s for boot...
==> vmware-iso.debian: Typing the boot command over VNC...
==> vmware-iso.debian: Waiting for SSH to become available...
==> vmware-iso.debian: Connected to SSH!
==> vmware-iso.debian: Gracefully halting virtual machine...
==> vmware-iso.debian: Waiting for clean up...
==> vmware-iso.debian: Deleting unnecessary files...
==> vmware-iso.debian: Deleting: builds/debian_aarch64/packer-debian.plist
==> vmware-iso.debian: Deleting: builds/debian_aarch64/packer-debian.scoreboard
==> vmware-iso.debian: Deleting: builds/debian_aarch64/vmware.log
==> vmware-iso.debian: Compacting all attached virtual disks...
==> vmware-iso.debian: Compacting virtual disk 1
==> vmware-iso.debian: Cleaning VMX prior to finishing up...
==> vmware-iso.debian: Detaching ISO from CD-ROM device sata0:1...
==> vmware-iso.debian: Disabling VNC server...
==> vmware-iso.debian: Exporting virtual machine...
==> vmware-iso.debian: Executing: ovftool builds/debian_aarch64/packer-debian.vmx builds/debian_aarch64/packer-debian.ova
Build 'vmware-iso.debian' finished after 7 minutes 24 seconds.

==> Wait completed after 7 minutes 24 seconds

==> Builds finished. The artifacts of successful builds are:
--> vmware-iso.debian: VM files in directory: builds/debian_aarch64

Acceptance Tests:

packer-plugin-vmware on  chore/remove-esx-support via 🐹 v1.24.6 
➜ go fmt ./...

packer-plugin-vmware on  chore/remove-esx-support via 🐹 v1.24.6 
➜ make build

packer-plugin-vmware on  chore/remove-esx-support via 🐹 v1.24.6 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan.johnson/Documents/GitHub/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan.johnson/.config/packer/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v2.0.0-dev_x5.0_darwin_arm64

packer-plugin-vmware on  chore/remove-esx-support via 🐹 v1.24.6 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.676s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.747s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.330s
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]

Rollback Plan

Not applicable.

@tenthirtyam tenthirtyam added this to the v2.0.0 milestone Aug 8, 2025
@tenthirtyam tenthirtyam added version/bump minor Version: Bump Minor chore Chore hypervisor/esx VMware ESX labels Aug 8, 2025
@tenthirtyam tenthirtyam self-assigned this Aug 8, 2025
@tenthirtyam tenthirtyam force-pushed the chore/remove-esx-support branch 9 times, most recently from 02bd501 to ec98b22 Compare August 15, 2025 18:40
@tenthirtyam tenthirtyam added version/bump major Version: Bump Major and removed version/bump minor Version: Bump Minor labels Aug 15, 2025
@tenthirtyam tenthirtyam mentioned this pull request Aug 16, 2025
Merged
@tenthirtyam tenthirtyam force-pushed the chore/remove-esx-support branch 5 times, most recently from c941129 to 6f36393 Compare August 18, 2025 17:29
@tenthirtyam tenthirtyam changed the title [wip] chore: remove esx support chore: remove esx support Aug 18, 2025
@tenthirtyam tenthirtyam force-pushed the chore/remove-esx-support branch from 6f36393 to c5c1253 Compare August 18, 2025 18:08
@tenthirtyam tenthirtyam marked this pull request as ready for review August 18, 2025 18:09
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 18, 2025 18:09
@tenthirtyam tenthirtyam mentioned this pull request Aug 19, 2025
Merged
@tenthirtyam tenthirtyam force-pushed the chore/remove-esx-support branch 2 times, most recently from ff8dc4c to bb909a2 Compare August 25, 2025 16:34
@tenthirtyam
chore: remove esx support
e70589b 
Removes support for VMware ESX.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore/remove-esx-support branch from bb909a2 to e70589b Compare August 28, 2025 01:47
@kp2099 kp2099 merged commit 94ca543 into main Aug 28, 2025
14 checks passed
@kp2099 kp2099 deleted the chore/remove-esx-support branch August 28, 2025 15:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
@tenthirtyam tenthirtyam added the breaking-change Breaking Change label Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JenGoldstrich JenGoldstrich Awaiting requested review from JenGoldstrich

1 more reviewer

@kp2099 kp2099 kp2099 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

breaking-change Breaking Change chore Chore hypervisor/esx VMware ESX version/bump major Version: Bump Major

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @kp2099