refactor: use log.Fatal for fatal error handling in main#317
Merged
tenthirtyam merged 1 commit intomainfrom Jun 5, 2025
Merged
refactor: use log.Fatal for fatal error handling in main#317tenthirtyam merged 1 commit intomainfrom
log.Fatal for fatal error handling in main#317tenthirtyam merged 1 commit intomainfrom
Conversation
Refactor fatal error handling in the main function to use `log.Fatal`. Previously, fatal errors were handled by printing to os.Stderr using `fmt.Fprintln` followed by an explicit `os.Exit(1)`.This change replaces that pattern with a single call to `log.Fatal(err)`. This is more idiomatic Go, makes the code more concise, and leverages the standard log package's capabilities, such as automatic timestamping of the error message. The program's exit behavior (exiting with status 1 on fatal error) remains the same. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
kp2099
approved these changes
Jun 5, 2025
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor fatal error handling in the main function to use
log.Fatal.Previously, fatal errors were handled by printing to os.Stderr using
fmt.Fprintlnfollowed by an explicitos.Exit(1).This change replaces that pattern with a single call tolog.Fatal(err). This is more idiomatic Go, makes the code more concise, and leverages the standard log package's capabilities, such as automatic timestamping of the error message. The program's exit behavior (exiting with status 1 on fatal error) remains the same.