Skip to content

refactor: remove deprecated ui.Message#316

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/remove-deprecated-ui.Message
Jun 5, 2025
Merged

refactor: remove deprecated ui.Message#316
tenthirtyam merged 1 commit intomainfrom
refactor/remove-deprecated-ui.Message

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented May 23, 2025

Replaces the SDK-deprecated ui.Message with ui.Say and ui.Sayf as applicable.

~/Downloads/packer-plugin-vmware git:[refactor/remove-deprecated-ui.Message]
go fmt ./...

~/Downloads/packer-plugin-vmware git:[refactor/remove-deprecated-ui.Message]
make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/johnsonryan/Downloads/packer-plugin-vmware/packer-plugin-vmware to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64

~/Downloads/packer-plugin-vmware git:[refactor/remove-deprecated-ui.Message]
make build

~/Downloads/packer-plugin-vmware git:[refactor/remove-deprecated-ui.Message]
make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.915s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.701s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.235s

@tenthirtyam
refactor: remove deprecated ui.Message
c86b492 
Replaces the deprecated `ui.Message` with `ui.Say` and `ui.Sayf` as applicable.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v1.2.0 milestone May 23, 2025
@tenthirtyam tenthirtyam self-assigned this May 23, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 23, 2025 14:52
kp2099
kp2099 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kp2099 kp2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is something we wanted to change in other plugins as well as the Message method seemed redundant.

We introduced it in sdk recently
hashicorp/packer-plugin-sdk#290

@tenthirtyam tenthirtyam merged commit a363b8d into main Jun 5, 2025
13 checks passed
@tenthirtyam tenthirtyam deleted the refactor/remove-deprecated-ui.Message branch June 5, 2025 14:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JenGoldstrich JenGoldstrich Awaiting requested review from JenGoldstrich

1 more reviewer

@kp2099 kp2099 kp2099 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

None yet

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @kp2099