Skip to content

refactor: remove snake_case#311

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/remove-snake-case
May 22, 2025
Merged

refactor: remove snake_case#311
tenthirtyam merged 1 commit intomainfrom
refactor/remove-snake-case

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented May 21, 2025

Removes the use of snake_case.

~/Downloads/packer-plugin-vmware git:[main]
go fmt ./...

~/Downloads/packer-plugin-vmware git:[main]
make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/johnsonryan/Downloads/packer-plugin-vmware/packer-plugin-vmware to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64

~/Downloads/packer-plugin-vmware git:[main]
make build

~/Downloads/packer-plugin-vmware git:[main]
make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.959s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    2.223s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.766s
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]

~/Downloads/packer-plugin-vmware git:[main]
golangci-lint run
0 issues.

@tenthirtyam tenthirtyam added this to the v1.2.0 milestone May 21, 2025
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 21, 2025 17:52
@tenthirtyam tenthirtyam self-assigned this May 21, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 21, 2025 17:52
JenGoldstrich
JenGoldstrich previously approved these changes May 21, 2025
View reviewed changes
Copy link
Copy Markdown

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, I noticed some small inconsistencies still, but nothing blocking or anything I feel strongly about, let me know what you think!

@tenthirtyam tenthirtyam force-pushed the refactor/remove-snake-case branch 4 times, most recently from 2d5193f to 3ff9c2a Compare May 21, 2025 23:01
@tenthirtyam tenthirtyam marked this pull request as draft May 21, 2025 23:35
@tenthirtyam tenthirtyam changed the title refactor: remove snake_case [wip] refactor: remove snake_case May 21, 2025
@tenthirtyam tenthirtyam force-pushed the refactor/remove-snake-case branch 4 times, most recently from 94da3ab to 551094c Compare May 22, 2025 02:19
@tenthirtyam
refactor: remove snake_case
7aac216 
Removes the use of snake_case.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the refactor/remove-snake-case branch from 551094c to 7aac216 Compare May 22, 2025 02:22
@tenthirtyam tenthirtyam changed the title [wip] refactor: remove snake_case refactor: remove snake_case May 22, 2025
@tenthirtyam tenthirtyam requested a review from JenGoldstrich May 22, 2025 02:24
@tenthirtyam tenthirtyam marked this pull request as ready for review May 22, 2025 02:24
@tenthirtyam tenthirtyam merged commit 2d62ee1 into main May 22, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the refactor/remove-snake-case branch May 22, 2025 05:11
@tenthirtyam tenthirtyam mentioned this pull request Jun 6, 2025
Merged
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

None yet

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @JenGoldstrich