Merged
Conversation
Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces improvements to the VMware Fusion by enhancing path handling for better security and reliability. It ensures all file paths are sanitized and converted to absolute paths before being used in commands. Additionally, it includes minor code adjustments for compliance with the
gosecstatic analysis tool.Path Handling Enhancements:
CompactDisk,CreateDisk,CreateSnapshot,IsRunning,Start,Stop,Clone) to sanitize file paths usingfilepath.Cleanand convert them to absolute paths withfilepath.Absbefore passing them to commands. This prevents potential path traversal vulnerabilities and ensures consistent path handling. [1] [2] [3] [4] [5] [6]Static Analysis Compliance:
//nolint:goseccomments to suppress false positives from static analysis tools for commands using dynamic paths. [1] [2] [3] [4] [5] [6] [7] [8]