Merged
Conversation
Adds `//nolint:gosec` for: - Expected permission value for `.plist` file. - Expected permission value for sample `.vmx` file for tests. - Expected permission value for sample `.lock` file for tests. - Sample PEM file for tests.
JenGoldstrich
approved these changes
May 12, 2025
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
//nolint:gosecfor:.plistfile..vmxfile for tests..lockfile for tests.Suppression of
goseclinting warnings://nolint:gosectoos.WriteFilecalls ingenerateNetmapConfigto bypass security linting for file permission issues. (builder/vmware/common/driver_workstation9.go, builder/vmware/common/driver_workstation9.goL343-R343)//nolint:goseccomments toos.WriteFilecalls in the following test cases to suppress security warnings:TestStepCleanVMX_floppyPath(builder/vmware/common/step_clean_vmx_test.go, builder/vmware/common/step_clean_vmx_test.goL41-R41)TestStepCleanVMX_isoPath(builder/vmware/common/step_clean_vmx_test.go, builder/vmware/common/step_clean_vmx_test.goL94-R94)TestStepCleanVMX_ethernet(builder/vmware/common/step_clean_vmx_test.go, builder/vmware/common/step_clean_vmx_test.goL150-R150)TestStepShutdown_locks(builder/vmware/common/step_shutdown_test.go, builder/vmware/common/step_shutdown_test.goL159-R159)TestStepCloneVMX(builder/vmware/vmx/step_clone_vmx_test.go, builder/vmware/vmx/step_clone_vmx_test.goL55-R61)Test-specific changes:
//nolint:goseccomments to thetestPemconstant and after the RSA private key block inTestSSHConfigPrepare_SSHPrivateKeyto suppress linting warnings for hardcoded credentials in test files. (builder/vmware/common/ssh_config_test.go, [1] [2]