Merged
Conversation
b6a7ae9 to
27704bd
Compare
JenGoldstrich
approved these changes
Apr 30, 2025
JenGoldstrich
left a comment
There was a problem hiding this comment.
You'll need to rebase this one, and I think our silly PR rules will dismiss this approval afterwards, feel free to @ me after you rebase and I'll re-approve
Adds/updates the comments in `driver.go`, as applicable, for correctness and clarity. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
27704bd to
ea3129d
Compare
Collaborator
Author
|
@JenGoldstrich Looks like it let it pass with the rebase. 🤷🏻♂️ i'll wait for the actions to pass and the S+M. |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds/updates the comments in
driver.go, as applicable, for correctness and clarity.