Skip to content

refactor: remove superfluous else#300

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/remove-superfluous-else
Apr 30, 2025
Merged

refactor: remove superfluous else#300
tenthirtyam merged 1 commit intomainfrom
refactor/remove-superfluous-else

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Description

  • Fix revive linter warnings related to superfluous-else.
  • Move variable declarations to their own lines where needed.
  • Simplify conditional blocks that had breaks followed by else clauses.
  • Maintain identical functionality while improving code readability.

- Fix revive linter warnings related to superfluous-else
- Move variable declarations to their own lines where needed
- Simplify conditional blocks that had breaks followed by else clauses
- Maintain identical functionality while improving code readability

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v1.2.0 milestone Apr 30, 2025
@tenthirtyam tenthirtyam self-assigned this Apr 30, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 30, 2025 14:03
Copy link
Copy Markdown

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🧽, very clean

@tenthirtyam tenthirtyam merged commit 1ad16c9 into main Apr 30, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the refactor/remove-superfluous-else branch April 30, 2025 16:18
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants