Skip to content

refactor: simplify access to methods/fields via direct calls#297

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/simplify-intermediate-access
Apr 28, 2025
Merged

refactor: simplify access to methods/fields via direct calls#297
tenthirtyam merged 1 commit intomainfrom
refactor/simplify-intermediate-access

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Refactored multiple instances where methods or fields were accessed through an intermediate field. These have been simplified to use direct access where applicable.

~/Downloads/packer-plugin-vmware git:[refactor/simplify-intermediate-access]
make generate
2025/04/27 20:53:09 Copying "docs" to ".docs/"
2025/04/27 20:53:09 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

~/Downloads/packer-plugin-vmware git:[refactor/simplify-intermediate-access]
make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/johnsonryan/Downloads/packer-plugin-vmware/packer-plugin-vmware to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64

~/Downloads/packer-plugin-vmware git:[refactor/simplify-intermediate-access]
make build

~/Downloads/packer-plugin-vmware git:[refactor/simplify-intermediate-access]
make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 7.175s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    3.584s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.677s
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]

@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Apr 28, 2025
@tenthirtyam tenthirtyam self-assigned this Apr 28, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 28, 2025 00:53
Copy link
Copy Markdown

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Refactored multiple instances where methods or fields were accessed through an intermediate field. These have been simplified to use direct access where applicable.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the refactor/simplify-intermediate-access branch from 567a99d to f24028f Compare April 28, 2025 16:18
@tenthirtyam tenthirtyam merged commit 0b19e2a into main Apr 28, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the refactor/simplify-intermediate-access branch April 28, 2025 16:24
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants