refactor: additional player consolidation#279
Merged
lbajolet-hashicorp merged 1 commit intomainfrom Apr 24, 2025
Merged
Conversation
a517b3c to
92ede4d
Compare
92ede4d to
9b66959
Compare
9b66959 to
a4c51bd
Compare
- Adds comments for the Workstation Player driver. - Updates version verification. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
a4c51bd to
dde38e5
Compare
Collaborator
Author
|
@lbajolet-hashicorp - Thanks for reviewing those other ones! Once this is approved and merged I'll move forward with the rebase of the Workstation consolidation and getting that closed out with Jenna's help. cc @JenGoldstrich |
lbajolet-hashicorp
approved these changes
Apr 23, 2025
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM! Left one curiosity question, but besides that, all good!
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces several enhancements and refactorings to the VMware Workstation Player driver code. The changes include renaming variables for clarity, adding new methods, and improving documentation.
Improvements and refactorings:
builder/vmware/common/driver.go: RenamedplayerRegistryKeytoplayerDhcpRegistryKeyand added constants for Linux paths.Enhancements to
PlayerDriver:builder/vmware/common/driver_player.go: Improved the documentation for these methods.Enhancements to Linux-specific code:
builder/vmware/common/driver_player_unix.go: Added documentation and methods for finding VMware executables and configuration paths, and verifying the VMware Workstation Player version. [1] [2] [3]Enhancements to Windows-specific code:
builder/vmware/common/driver_player_windows.go: Added documentation and methods for finding VMware executables, reading registry paths, and handling configuration paths. [1] [2] [3] [4] [5]