Skip to content

chore: fusion update log msg#278

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore/fusion-update-log-msg
Apr 22, 2025
Merged

chore: fusion update log msg#278
lbajolet-hashicorp merged 1 commit intomainfrom
chore/fusion-update-log-msg

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Summary

Includes updates to the builder/vmware/common/driver_fusion.go file to improve logging messages and code comments. The most important changes include adding a comment header for VMware Fusion, modifying a log message for clarity, and removing an outdated comment.

@tenthirtyam tenthirtyam added the chore Chore label Feb 23, 2025
@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Feb 23, 2025
@tenthirtyam tenthirtyam self-assigned this Feb 23, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 23, 2025 22:35
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the chore/fusion-update-log-msg branch from 8583a88 to 45f3902 Compare March 21, 2025 14:21
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the changes, mostly nitpicks but since the PR is small, I'll wait until they're addressed before approving it.

@tenthirtyam tenthirtyam force-pushed the chore/fusion-update-log-msg branch from 45f3902 to 479ccd5 Compare March 21, 2025 15:23
Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the chore/fusion-update-log-msg branch from 479ccd5 to 8ded20c Compare April 22, 2025 19:25
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 8577d7b into main Apr 22, 2025
14 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/fusion-update-log-msg branch April 22, 2025 19:50
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants