refactor: workstation license check#277
Merged
lbajolet-hashicorp merged 1 commit intomainfrom Apr 22, 2025
Merged
Conversation
8652848 to
d4f074c
Compare
lbajolet-hashicorp
previously approved these changes
Mar 21, 2025
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM! Left a small question on one constant, but the rest of the changes look good to me.
d4f074c to
f448275
Compare
Refactors `workstationLicenseCheck` to support updates to licensing models. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
f448275 to
4421b25
Compare
lbajolet-hashicorp
approved these changes
Apr 22, 2025
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM, thanks @tenthirtyam!
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
workstationLicenseCheckto enhance the handling of VMware Workstation license checks and improve test coverage. The most important changes include adding a new constant for a version that does not require a license, modifying the license check logic, and adding comprehensive unit tests for the updated logic.Enhancements to license handling:
builder/vmware/common/driver.go: Added a new constantworkstationNoLicenseVersionfor version 17.6.2, which no longer requires a license for use - free for personal and commercia use - and provided notes and references for version changes.builder/vmware/common/driver_workstation_unix.go: Updated theworkstationCheckLicensefunction to skip the license check for versions greater than or equal toworkstationNoLicenseVersionand added logging for different scenarios.Improvements to test coverage:
builder/vmware/common/driver_workstation_unix_test.go: Added mock functions and a new testable functiontestableWorkstationCheckLicenseto facilitate unit testing. Implemented multiple test cases to cover various scenarios, including version checks and license file detection.Resolves #242