Skip to content

chore: update log messages#261

Merged
lbajolet-hashicorp merged 1 commit intovmware:mainfrom
tenthirtyam:chore/update-log-messages
Nov 26, 2024
Merged

chore: update log messages#261
lbajolet-hashicorp merged 1 commit intovmware:mainfrom
tenthirtyam:chore/update-log-messages

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Nov 15, 2024

Summary

Technical Debt: Updates log messages based on INFO or WARN context.

@tenthirtyam tenthirtyam added the chore Chore label Nov 15, 2024
@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Nov 15, 2024
@tenthirtyam tenthirtyam self-assigned this Nov 15, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner November 15, 2024 03:15
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks @tenthirtyam !

I left a couple comments on the changes for findFile, the updated prototype for the function looks a tad weird to me, especially with how verbose is inferred from the list of options, and only checks the first one. I'll let you address that and I'll come back after for a second pass.

Pre-approving since there's not a lot to change here

Updates log messages based on INFO or WARN context.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

@lbajolet-hashicorp - I've addressed the concerns and this one is ready again for you.

Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the reroll @tenthirtyam !

@lbajolet-hashicorp lbajolet-hashicorp merged commit 691badd into vmware:main Nov 26, 2024
@tenthirtyam tenthirtyam deleted the chore/update-log-messages branch January 30, 2025 02:00
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants