Skip to content

chore: fusion log messages#253

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore/fusion-log-messages
Nov 8, 2024
Merged

chore: fusion log messages#253
lbajolet-hashicorp merged 1 commit intomainfrom
chore/fusion-log-messages

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Oct 11, 2024

Description

Sets the information log messages in the Fusion driver to be prefaces with [INFO].

Testing

packer-plugin-vmware on  chore/fusion-log-messages [$] via 🐹 v1.23.2 
➜ go fmt ./...

packer-plugin-vmware on  chore/fusion-log-messages [$] via 🐹 v1.23.2 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 7.531s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.550s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.967s

packer-plugin-vmware on  chore/fusion-log-messages [$] via 🐹 v1.23.2 took 23.4s 
➜ make build

packer-plugin-vmware on  chore/fusion-log-messages [$] via 🐹 v1.23.2 took 5.0s 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_arm64

@tenthirtyam
chore: fusion log messages
5c09079 
Sets the information log messages in the Fusion driver to be prefaces with [INFO].

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Oct 11, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 11, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 11, 2024 00:33
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Nov 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 416379a into main Nov 8, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/fusion-log-messages branch November 8, 2024 15:05
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp