Skip to content

chore: address parsing#245

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore/address-parsing
Aug 27, 2024
Merged

chore: address parsing#245
lbajolet-hashicorp merged 1 commit intomainfrom
chore/address-parsing

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Aug 26, 2024 •
edited
Loading

Summary

Updates the following in driver_parser.go

  • hardware - length of the octets and ensure address is 6 bytes.
  • subnet - ensure within the 0-255 range instead of parsing a value larger than 255.

Testing

packer-plugin-vmware on  chore/address-parsing [$] via 🐹 v1.23.0 
➜ go fmt ./...                             

packer-plugin-vmware on  chore/address-parsing [$] via 🐹 v1.23.0 
➜ go build    

packer-plugin-vmware on  chore/address-parsing [$] via 🐹 v1.23.0 took 5.0s 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 7.202s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    3.007s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    4.036s

packer-plugin-vmware on  chore/address-parsing [$] via 🐹 v1.23.0 took 13.2s 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/packer-plugin-vmware/packer-plugin-vmware to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64

Reference

Resolves the following:

@tenthirtyam tenthirtyam added tech-debt security Security issues/fixes. chore Chore labels Aug 26, 2024
@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Aug 26, 2024
@tenthirtyam tenthirtyam self-assigned this Aug 26, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 26, 2024 18:18
@tenthirtyam tenthirtyam force-pushed the chore/address-parsing branch from 7ed863f to f10415b Compare August 26, 2024 18:58
@tenthirtyam
chore: address parsing
08f3377 
- `hardware` - length of the octets and ensure address is 6 bytes.
- `subnet` - ensure within the 0-255 range instead of parsing a value larger than 255.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore/address-parsing branch from f10415b to 08f3377 Compare August 26, 2024 18:58
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 0ae4274 into main Aug 27, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/address-parsing branch August 27, 2024 18:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore security Security issues/fixes.

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp