Skip to content

chore(ci): add codeql analysis#238

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore(ci)/add-codeql-analysis
Aug 21, 2024
Merged

chore(ci): add codeql analysis#238
lbajolet-hashicorp merged 1 commit intomainfrom
chore(ci)/add-codeql-analysis

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Aug 14, 2024

Summary

Adds CodeQL Analysis.

Required 1.N.P syntax in go.mod which is used in go.version.

(Also moved hashicorp/go-version to a direct requirement.)

@tenthirtyam tenthirtyam added the chore Chore label Aug 14, 2024
@tenthirtyam tenthirtyam added this to the v1.1.1 milestone Aug 14, 2024
@tenthirtyam tenthirtyam self-assigned this Aug 14, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 14, 2024 18:27
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple questions on the changes, but overall this makes sense!

I'm pre-approving not to block, I'll let you respond to those questions before triggering the merge, but lgtm

Adds CodeQL Analysis.

Also moved `hashicorp/go-version` to a direct requirement.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore(ci)/add-codeql-analysis branch from 4412b1c to 9fd37e1 Compare August 21, 2024 20:43
@lbajolet-hashicorp lbajolet-hashicorp merged commit 2847481 into main Aug 21, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore(ci)/add-codeql-analysis branch August 21, 2024 20:53
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants