refactor: consolidate workstation driver#232
Merged
tenthirtyam merged 1 commit intomainfrom Jun 10, 2025
Merged
Conversation
5cafb40 to
d7e0e36
Compare
789045f to
1af8586
Compare
1af8586 to
cb66913
Compare
5a339b7 to
fec4960
Compare
eb393b0 to
6cfd90a
Compare
283ca55 to
3c0da60
Compare
3c0da60 to
de8411e
Compare
ac0beaa to
773cbcc
Compare
c706c15 to
d8c18ac
Compare
- Consolidates `Workstation9Driver` and `Workstation10Driver` to `WorkstationrDriver` within `driver_workstation.go`. - Addresses the deprecation of `syscall.StringToUTF16Ptr` with `windows.UTF16PtrFromString` in `readRegString`. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
Collaborator
Author
|
@kp2099 and @JenGoldstrich - at long last 🤣 this pull request that consolidates the Workstation drivers is now ready for review! |
JenGoldstrich
approved these changes
Jun 10, 2025
JenGoldstrich
left a comment
There was a problem hiding this comment.
LGTM, I did not run the tests mentioned due to not having a current VMware setup, but if you do the regression testing you mentioned in DMs I'm sure it'll be fine, plus the tests you already ran
Collaborator
Author
|
Thank you, Jenna! 😄 |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workstation9DriverandWorkstation10DrivertoWorkstationrDriverwithindriver_workstation.go.syscall.StringToUTF16Ptrwithwindows.UTF16PtrFromStringinreadRegString.Testing
**PASS**: VMware Workstation 17.6.2 on Windows 11 Pro 24H2
**PASS**: VMware Workstation 17.6.3 on Ubuntu Desktop 24.04