refactor: register virtual machine#224
Merged
lbajolet-hashicorp merged 1 commit intomainfrom Jul 29, 2024
Merged
Conversation
lbajolet-hashicorp
approved these changes
Jul 26, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Just left one comment regarding usage of log.Printf in addition to ui.Error as it feels like a suspender+belt kind of situation, but aside from that LGTM!
Pre-approving to not delay a later merge.
271b60d to
edde6b3
Compare
- Moves the destroy timeout value to a constant. - Avoids logging an error before checking if it exists. - Combines the timeout error message logging and UI notification: Since both actions occur together, keep them within the same conditional block to avoid repetition. - Uses a ticker for periodic checks instead of manually sleeping and checking. This is more idiomatic and readable. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
edde6b3 to
ccb79b3
Compare
Contributor
|
FYI: I replaced a couple of |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Standard