Skip to content

chore: update run config#223

Merged
nywilken merged 1 commit intomainfrom
chore/update-run-config
Jul 17, 2024
Merged

chore: update run config#223
nywilken merged 1 commit intomainfrom
chore/update-run-config

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Jul 8, 2024

Description

  • Updates comments for more streamlined documentation.
  • Removes the use of "magic" numbers and defines constants.

Testing

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 took 10.0s 
➜ go fmt ./... 
builder/vmware/common/run_config_test.go

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 
➜ make generate
2024/07/07 23:09:07 Copying "docs" to ".docs/"
2024/07/07 23:09:07 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 
➜ make build   

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 
➜ make test    
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.592s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    2.271s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    1.836s

packer-plugin-vmware on  chore-update-run-config [$✘!] via 🐹 v1.22.5 took 8.9s 
➜ make dev     
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

@tenthirtyam
chore: update run config
98a9f7c 
- Updates comments for more streamlined documentation.
- Removes the use of "magic" numbers and defines constants.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam added this to the v1.0.12 milestone Jul 8, 2024
@tenthirtyam tenthirtyam self-assigned this Jul 8, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner July 8, 2024 03:16
nywilken
nywilken approved these changes Jul 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 7fa57d8 into main Jul 17, 2024
@nywilken nywilken deleted the chore/update-run-config branch July 17, 2024 16:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

1 more reviewer

@nywilken nywilken nywilken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore documentation Documentation

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @nywilken