feat: enable virtual hardware-assisted virtualization#213
Merged
Conversation
nywilken
reviewed
Jul 2, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
This looks good to me. I left a couple of suggestions to lean on the template engine for converting boolean types to strings.
a715e6f to
5bb2ad3
Compare
nywilken
reviewed
Jul 2, 2024
Adds explicit option to enable virtual hardware-assisted virtualization. Ref: #41 Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
5bb2ad3 to
17e8dd4
Compare
nywilken
approved these changes
Jul 5, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
The updates look great! 
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit option to enable virtual hardware-assisted virtualization.
vhv_enabled(bool) - Enable virtual hardware-assisted virtualization for the virtual machine. Defaults tofalse.Testing
If
vhv_enabled = true, results in the following in the.vmx:If
vhv_enabled = falseor not provided, results in the following in the.vmx:Reference
Closes #41