Conversation
Closed
709ca40 to
694739f
Compare
nywilken
reviewed
Jul 5, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
Overall this looks good. I left a few suggestions. Let me know what you think. If you prefer to keep it as is. Just let me know and I will approve and merge.
7cbb987 to
45c037f
Compare
Adds options to explicitly enable UEFI and Secure Boot (required UEFI). Also, updates the descriptions for the documentation and moves the CoreCount right after CPUCount to maintain a logical order. Ref: #58 Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
45c037f to
f174d3a
Compare
nywilken
approved these changes
Jul 5, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
This looks good to go. Thanks for the updates.
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds options to explicitly enable UEFI and Secure Boot (requires UEFI).
Introduces optional
firmware. Allowed values arebios,uefi, anduefi-secure(for secure boot). Defaults to the recommended firmware type for the guest operating system.Note the use of "uefi" instead of "efi" as seen in
packer-plugin-vsphereas this is more correct and aligns with the UI and the secure boot key in the.vmxfile.Testing
Reference
Closes #58