Skip to content

chore: update virtual hardware versions#211

Merged
nywilken merged 1 commit intomainfrom
chore/update-virtual-harware-versions
Jul 6, 2024
Merged

chore: update virtual hardware versions#211
nywilken merged 1 commit intomainfrom
chore/update-virtual-harware-versions

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Jun 30, 2024 •
edited
Loading

Description

  • Updates version to an int instead of a string.
  • Adds a check in Prepare() to ensure the value is > the minimum.
  • Updates the documentation in config.go.
  • Adds constants for the minimum and default virtual hardware versions.

Important

  • Minimum is now 13 instead of 9.
  • Default is 19 instead of 9.

Refer to Broadcom KB 315655

Testing

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ go fmt ./... 

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ make generate
2024/06/30 14:52:08 Copying "docs" to ".docs/"
2024/06/30 14:52:08 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ make build   

packer-plugin-vmware on  chore/update-virtual-harware-versions
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.598s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.811s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.122s

packer-plugin-vmware on  chore/update-virtual-harware-versions
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/ryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Personal/packer-plugin-vmware/packer-plugin-vmware to /Users/ryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.12-dev_x5.0_darwin_arm64

Tested on:

  • macOS 14.5 with VMware Fusion 13.5 (MacBook Pro M2 Max)
  • Windows 11 22H2 with VMware Workstation 17.5 (Dell OptiPlex 7050 i7)

The virtual machines were able to boot with and without configuration of the version.

.vmx results for the default:

virtualhw.productcompatibility = "hosted"
virtualhw.version = "19"
vmci0.id = "1861462627"

Reference

@tenthirtyam tenthirtyam added this to the On Deck milestone Jun 30, 2024
@tenthirtyam tenthirtyam self-assigned this Jun 30, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner June 30, 2024 19:00
@tenthirtyam tenthirtyam changed the title chore: update virtual harware versions chore: update virtual hardware versions Jul 5, 2024
nywilken
nywilken approved these changes Jul 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken
Copy link
Copy Markdown
Contributor

nywilken commented Jul 5, 2024

@tenthirtyam the change looks good overall but needs a rebase.

@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

tenthirtyam commented Jul 5, 2024

@tenthirtyam the change looks good overall but needs a rebase.

I'm on it!

@tenthirtyam
chore: update virtual hardware versions
ebf7537 
- Updates `version` to an `int` instead of a string.
- Adds a check in `Prepare()` to ensure the value is > the minimum.
- Adds constants for the minimum and default virtual hardware versions.

NOTE:

- Minimum is now 13 instead of 9.
- Default is 19 instead of 9.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
- Updates the documentation in `config.go`.
@tenthirtyam tenthirtyam force-pushed the chore/update-virtual-harware-versions branch from 598996a to ebf7537 Compare July 5, 2024 19:18
@tenthirtyam tenthirtyam modified the milestones: On Deck, v1.0.12 Jul 5, 2024
@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

tenthirtyam commented Jul 5, 2024

@tenthirtyam the change looks good overall but needs a rebase.

Ready! ✅

@nywilken nywilken merged commit 330dc55 into main Jul 6, 2024
@nywilken nywilken deleted the chore/update-virtual-harware-versions branch July 6, 2024 23:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

1 more reviewer

@nywilken nywilken nywilken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @nywilken