Skip to content

refactor: update esx5 to esxi#210

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
refactor/update-esx5-to-esxi
Aug 27, 2024
Merged

refactor: update esx5 to esxi#210
lbajolet-hashicorp merged 1 commit intomainfrom
refactor/update-esx5-to-esxi

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Jun 27, 2024 •
edited
Loading

Description

  • Updates references to "ESX5" to "ESXi".
  • Sets remote_type of esxi as preferred and esx5 as deprecated.
  • Updates messages and comments, including deprecation message.
  • Updates tests to use more standard remote_type, remote_username, and remote_password.
  • Updates description for the Config configuration.

Testing

Basic: ✅ PASS

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 took 7.6s 
➜ go fmt ./... 

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 
➜ make generate
2024/08/22 10:53:33 Copying "docs" to ".docs/"
2024/08/22 10:53:33 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 took 4.6s 
➜ make build

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 
➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.690s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    3.552s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    4.720s

packer-plugin-vmware on  refactor/update-esx5-to-esxi [⇕$!] via 🐹 v1.23.0 took 15.3s 
➜ make dev
packer plugins install --path packer-plugin-vmware "github.com/hashicorp/vmware"
Successfully installed plugin github.com/hashicorp/vmware from /Users/johnsonryan/Library/Mobile Documents/com~apple~CloudDocs/Code/Work/packer-plugin-vmware/packer-plugin-vmware to /Users/johnsonryan/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64

E2E: ✅ PASS

==> vmware-iso.appliance (shell-local): Running local shell script: /var/folders/dw/5mlbs0q50gs1qkqmgyx1g6dr0000gp/T/packer-shell1275577246
    vmware-iso.appliance (shell-local): > Setting the output and OVF paths ...
    vmware-iso.appliance (shell-local): > Moving the OVF files to ../output-appliance/appliance ...
    vmware-iso.appliance (shell-local): > Removing the ../output-appliance/appliance/appliance.mf file from the OVF directory ...
    vmware-iso.appliance (shell-local): > Adding the appliance version v0.0.1 to the OVF template ...
    vmware-iso.appliance (shell-local): > Creating the OVA file at ../output-appliance/appliance_v0.0.1.ova ..
    vmware-iso.appliance (shell-local): Opening OVF source: ../output-appliance/appliance/appliance.ovf
    vmware-iso.appliance (shell-local): Opening OVA target: ../output-appliance/appliance_v0.0.1.ova
    vmware-iso.appliance (shell-local): Writing OVA package: ../output-appliance/appliance_v0.0.1.ova
    vmware-iso.appliance (shell-local): Transfer Completed
    vmware-iso.appliance (shell-local): Warning:
    vmware-iso.appliance (shell-local):  - No manifest file found.
    vmware-iso.appliance (shell-local):  - No supported manifest(sha1, sha256, sha512) entry found for: 'appliance-disk1.vmdk'.
    vmware-iso.appliance (shell-local): Completed successfully
    vmware-iso.appliance (shell-local): > Removing files that are no longer required ...
    vmware-iso.appliance (shell-local): > Done!
Build 'vmware-iso.appliance' finished after 12 minutes 39 seconds.

==> Wait completed after 12 minutes 39 seconds

==> Builds finished. The artifacts of successful builds are:
--> vmware-iso.appliance: VM files in directory: output-appliance

Downloads/validated-solutions-for-cloud-foundation-d259796887ebaa52c50af4011be4b6d6526adc8f/appliance took 12m 43.4s 
✦5 ➜

And if using esx5 the following is logged:

2024/08/22 12:26:05 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64 plugin: 2024/08/22 12:26:05 Serving a plugin connection...
2024/08/22 12:26:05 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64 plugin: 2024/08/22 12:26:05 [TRACE] starting builder iso
2024/08/22 12:26:05 packer-plugin-vmware_v1.1.1-dev_x5.0_darwin_amd64 plugin: 2024/08/22 12:26:05 The 'esx5' remote type is deprecated. Please use 'esxi' instead.
2024/08/22 12:26:05 [INFO] Starting internal plugin packer-provisioner-shell
2024/08/22 12:26:05 Starting plugin: /usr/local/bin/packer []string{"/usr/local/bin/packer", "execute", "packer-provisioner-shell"}

@tenthirtyam tenthirtyam self-assigned this Jun 27, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner June 27, 2024 04:47
@tenthirtyam tenthirtyam force-pushed the refactor/update-esx5-to-esxi branch from 50873ca to 87284ef Compare June 28, 2024 00:58
@tenthirtyam tenthirtyam changed the title 🚧 refactor: update esx5 to esxi refactor: update esx5 to esxi Jun 28, 2024
@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

tenthirtyam commented Jun 28, 2024

@nywilken - let's discuss if this should introduce a minimumEsxiVersion to support 7.0 and later.

@nywilken
Copy link
Copy Markdown
Contributor

nywilken commented Jul 1, 2024

let me put sometime for tomorrow to discuss. I feel like this change plus ovf minimum version require a minor or even major.

@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

tenthirtyam commented Jul 1, 2024

Roger that. I was thinking minor. Let's's chat - been doggie in a bit on some issues and factoring that I see needed.

@tenthirtyam tenthirtyam added this to the On Deck milestone Jul 5, 2024
@tenthirtyam tenthirtyam added the hypervisor/esx VMware ESX label Jul 18, 2024
@tenthirtyam tenthirtyam marked this pull request as draft July 19, 2024 02:06
@tenthirtyam tenthirtyam force-pushed the refactor/update-esx5-to-esxi branch 6 times, most recently from f38fa0a to 5c5ff5f Compare August 9, 2024 18:15
@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

tenthirtyam commented Aug 9, 2024

Ready for initial review; e2e validations are still in flight with the latest updates.

@tenthirtyam tenthirtyam marked this pull request as ready for review August 9, 2024 18:21
@tenthirtyam tenthirtyam force-pushed the refactor/update-esx5-to-esxi branch from 5c5ff5f to 6eecd91 Compare August 22, 2024 14:55
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on esx5 vs. esxi, but overall LGTM!

I'll let you address this and will come back later for another pass, but pre-approving in the meantime

@tenthirtyam tenthirtyam force-pushed the refactor/update-esx5-to-esxi branch from 6eecd91 to b9b4318 Compare August 27, 2024 18:52
@tenthirtyam
refactor: update esx5 to esxi
ba4cca8 
Updates references to "ESX5" to "ESXi".

Sets `remote_type` of `esxi` as preferred and `esx5` as deprecated.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the refactor/update-esx5-to-esxi branch from b9b4318 to ba4cca8 Compare August 27, 2024 18:55
@lbajolet-hashicorp lbajolet-hashicorp merged commit a50a401 into main Aug 27, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the refactor/update-esx5-to-esxi branch August 27, 2024 18:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 31, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nywilken nywilken Awaiting requested review from nywilken

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

Assignees

@tenthirtyam tenthirtyam

Labels

hypervisor/esx VMware ESX

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tenthirtyam @nywilken @lbajolet-hashicorp