Add Feature: create initial snapshot of VM after clean-up#21
Merged
sylviamoss merged 8 commits intovmware:mainfrom May 17, 2021
Merged
Add Feature: create initial snapshot of VM after clean-up#21sylviamoss merged 8 commits intovmware:mainfrom
sylviamoss merged 8 commits intovmware:mainfrom
Conversation
|
|
sylviamoss
reviewed
May 11, 2021
Comment on lines
+37
to
+40
| state.Put("snapshot_created", true) | ||
| } else { | ||
| state.Put("snapshot_skipped", true) | ||
| } |
There was a problem hiding this comment.
Is there any reason you are adding these information to the state? I don't see them being used somewhere else 🤔
Contributor
Author
There was a problem hiding this comment.
those are at the moment mainly for testing and to have the state as an internal checklist, but are not necessarily needed.
There was a problem hiding this comment.
Oh sorry, I didn't notice it was being used for testing. Sounds good!
sylviamoss
reviewed
May 11, 2021
Co-authored-by: Sylvia Moss <sylviamoss.m@gmail.com>
sylviamoss
approved these changes
May 17, 2021
sylviamoss
left a comment
There was a problem hiding this comment.
This is looking good 👍🏼
It is missing only the generated docs which you get by running go generate ./...
Co-authored-by: Sylvia Moss <sylviamoss.m@gmail.com>
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateSnapshotmethod to create snapshotssimply set the
"snapshot_name"field inside the builder's config to create an initial snapshot (if not set, snapshot creation will be skipped)Closes #20