refactor: consolidate fusion driver#208
Conversation
2411066 to
fcbd57d
Compare
ba56970 to
e589d5e
Compare
e589d5e to
1de78ff
Compare
437bd61 to
bc81082
Compare
| err := driver.Verify() | ||
|
|
||
| log.Printf("Testing against driver %T, Success: %t", driver, err == nil) | ||
| log.Printf("Using driver %T, Success: %t", driver, err == nil) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| } | ||
|
|
||
| log.Printf("skipping %T because it failed with the following error %s", driver, err) | ||
| log.Printf("Skipping %T because it failed with the following error %s", driver, err) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
|
@lbajolet-hashicorp - this one is good to go now! |
0aea06f to
79c9c26
Compare
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Left a couple comments on regexp management, but aside from that LGTM!
Pre-approving
79c9c26 to
018e73a
Compare
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Left one last comment since there's one regexp that isn't compiled outside the code, I'll let you answer my comment, if there's a good reason to have it compiled in the CheckOvfToolVersion function we can roll with it
- Consolidates `Fusion5Driver` and `Fusion6Driver` to `FusionDriver` within `driver_fusion.go`. - Added constants to simplify functions. - Added functions to remove repedative path joins. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
018e73a to
08cad59
Compare
|
LGTM, thanks for the reroll @tenthirtyam! Merging as soon as tests go green |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Consolidates
Fusion5DriverandFusion6DrivertoFusionDriverwithindriver_fusion.go.Note: The minimum version should be set to VMware Fusion 13 per the Broadcom Product Lifecycle. However, we could hold this change, leave it as 6, and update all minimum versions simultaneously.
Testing
✅ Basic: PASS 🚀
Test Results
✅ End-to-End: PASS 🚀
Test Results