Skip to content

fix: update StepSSHKeyGen position#203

Merged
nywilken merged 1 commit intomainfrom
fix/update-stepsshkeygen-postion
Jul 2, 2024
Merged

fix: update StepSSHKeyGen position#203
nywilken merged 1 commit intomainfrom
fix/update-stepsshkeygen-postion

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Description

Moves &communicator.StepSSHKeyGen position to earlier in each builder.

Testing

packer-plugin-vmware on  fix/update-stepsshkeygen-postion
✦ ➜ go fmt ./...

packer-plugin-vmware on  fix/update-stepsshkeygen-postion
✦ ➜ make generate
2024/06/25 20:07:52 Copying "docs" to ".docs/"
2024/06/25 20:07:52 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vmware on  fix/update-stepsshkeygen-postion
✦ ➜ make build

packer-plugin-vmware on  fix/update-stepsshkeygen-postion
✦ ➜ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 7.279s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    3.271s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    4.406s

Reference

Closes #177

Moves `&communicator.StepSSHKeyGen` position to earlier in each builder.

Ref: #177

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added the bug Bug label Jun 26, 2024
@tenthirtyam tenthirtyam added this to the v1.0.12 milestone Jun 26, 2024
@tenthirtyam tenthirtyam requested a review from nywilken June 26, 2024 00:14
@tenthirtyam tenthirtyam self-assigned this Jun 26, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner June 26, 2024 00:14
Copy link
Copy Markdown
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 5639111 into main Jul 2, 2024
@nywilken nywilken deleted the fix/update-stepsshkeygen-postion branch July 2, 2024 19:45
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSHPublicKey created too late for cd_content

2 participants