fix: generate default netmap.conf, if required#198
Merged
Conversation
73f8583 to
b2ba32a
Compare
7968a8c to
b5171c0
Compare
b5171c0 to
4ce7b97
Compare
860989f to
ba6accd
Compare
nywilken
reviewed
Jul 2, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
I left a few suggestions. I'm still working through the PR.
ba6accd to
2ebbe20
Compare
Generates the `netmap.conf` in the default location if the file does not exist in the default path or the alternate path. There have been reported issues (GH, Discuss, blogs) of fresh installations of Workstation 17 (and 16) not generating the default file which will cause a build to fail on a newly configured system. Ref: #65 Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
2ebbe20 to
d12f8ff
Compare
nywilken
approved these changes
Jul 5, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
The updates look great. Thanks for tackling this PR.
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generates the
netmap.confin the default location if the file does not exist in the default path or the alternate path. The file generated is an exact match to the default based on a template.There have been reported issues (GH, Discuss, blogs) of fresh installations of Workstation 17 (and 16) not generating the default file which will cause a build to fail on a newly configured system.
cc @mikeroySoft, Product Manager for Workstation.
Reference
Closes #65