chore: replace reflect.DeepEqual#196
Merged
lbajolet-hashicorp merged 1 commit intomainfrom May 28, 2024
Merged
Conversation
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Left one quick comment on the usage of an else, and this looks good to me, however may I ask why we want to get rid of those DeepEqual statements? Have they become problematic in some way?
Replaces the use of `reflect.DeepEqual` with `errors.Is` for error comparison. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
214f2bd to
d544221
Compare
lbajolet-hashicorp
approved these changes
May 28, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Reroll looks good to me!
I still wonder why we want to get rid of those reflect.DeepEqual though, not that it's a problem to remove them but I can't help but ask what's the motivation behind the change :)
Merging this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the use of
reflect.DeepEqualwitherrors.Isfor error comparison.Testing