Skip to content

chore(deps): bump golang/x/net from 0.21.0 to 0.25.0#193

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore(deps)/golang-x-net
May 23, 2024
Merged

chore(deps): bump golang/x/net from 0.21.0 to 0.25.0#193
lbajolet-hashicorp merged 1 commit intomainfrom
chore(deps)/golang-x-net

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented May 14, 2024 •
edited
Loading

Summary

Bump golang/x/net from 0.21.0 to 0.25.0.

Ref: https://github.com/hashicorp/packer-plugin-vmware/security/dependabot/26

Testing

➜  packer-plugin-vmware git:(chore(deps)/golang-x-net) go get -u golang.org/x/net
go: downloading golang.org/x/net v0.25.0
➜  packer-plugin-vmware git:(chore(deps)/golang-x-net) ✗ go mod tidy
➜  packer-plugin-vmware git:(chore(deps)/golang-x-net) ✗ make build
➜  packer-plugin-vmware git:(chore(deps)/golang-x-net) ✗ make test
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 7.111s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    2.917s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    3.796s

@tenthirtyam tenthirtyam added dependencies Dependencies chore Chore labels May 14, 2024
@tenthirtyam tenthirtyam added this to the v1.0.12 milestone May 14, 2024
@tenthirtyam tenthirtyam self-assigned this May 14, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 14, 2024 16:36
lbajolet-hashicorp
lbajolet-hashicorp reviewed May 23, 2024
View reviewed changes
lbajolet-hashicorp
lbajolet-hashicorp approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but given the other PRs that update dependencies, I'm worried there will have to be a rebase for this one.

@tenthirtyam
Copy link
Copy Markdown
Collaborator Author

tenthirtyam commented May 23, 2024

I'll rebase and verify!

@tenthirtyam tenthirtyam force-pushed the chore(deps)/golang-x-net branch 2 times, most recently from 8a8847c to 0f0b18e Compare May 23, 2024 21:05
@tenthirtyam tenthirtyam changed the title chore(deps): bump golang/x/net from 0.18.0 to 0.25.0 chore(deps): bump golang/x/net from 0.21.0 to 0.25.0 May 23, 2024
@tenthirtyam
chore(deps): bump golang/x/net from 0.21.0 to 0.25.0
e75bed2 
Bump golang/x/net from 0.21.0 to 0.25.0.

- GHSA-4v7x-pqxf-cx7m

Ref: https://github.com/hashicorp/packer-plugin-vmware/security/dependabot/26

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore(deps)/golang-x-net branch from 0f0b18e to e75bed2 Compare May 23, 2024 21:07
@lbajolet-hashicorp lbajolet-hashicorp merged commit 15beee7 into main May 23, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore(deps)/golang-x-net branch May 23, 2024 21:19
@vmware vmware locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore dependencies Dependencies

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp