Skip to content

chore: address io/ioutil depreciation#190

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore/ioutil-depreciation
May 23, 2024
Merged

chore: address io/ioutil depreciation#190
lbajolet-hashicorp merged 1 commit intomainfrom
chore/ioutil-depreciation

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Summary

io/ioutil is deprecated as of Go 1.16:

  • Updates ioutil.TempDir to os.MkdirTemp.
  • Updates ioutil.TempFile to os.CreateTemp.
  • Updates ioutil.ReadFile to os.ReadFile.
  • Updates ioutil.WriteFile to os.WriteFile.
  • Updates ioutil.ReadAll to io.ReadAll.

Testing

packer-plugin-vmware on  chore/ioutil-depreciation via 🐹 v1.22.3 make generate
2024/05/11 01:00:04 Copying "docs" to ".docs/"
2024/05/11 01:00:04 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...


packer-plugin-vmware on  chore/ioutil-depreciation via 🐹 v1.22.3 make build   


packer-plugin-vmware on  chore/ioutil-depreciation via 🐹 v1.22.3 took 2.6s make test    
?       github.com/hashicorp/packer-plugin-vmware       [no test files]
?       github.com/hashicorp/packer-plugin-vmware/version       [no test files]
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/common 6.592s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/iso    1.774s
ok      github.com/hashicorp/packer-plugin-vmware/builder/vmware/vmx    2.175s

io/ioutil is deprecated as of Go 1.16:

- Updates `ioutil.TempDir` to `os.MkdirTemp`.
- Updates `ioutil.TempFile` to `os.CreateTemp`.
- Updates `ioutil.ReadFile` to `os.ReadFile`.
- Updates `ioutil.WriteFile` to `os.WriteFile`.
- Updates `ioutil.ReadAll` to `io.ReadAll`.
@tenthirtyam tenthirtyam added dependencies Dependencies chore Chore labels May 11, 2024
@tenthirtyam tenthirtyam added this to the v1.0.12 milestone May 11, 2024
@tenthirtyam tenthirtyam self-assigned this May 11, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 11, 2024 05:01
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 0f1736d into main May 23, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore/ioutil-depreciation branch May 23, 2024 20:37
@vmware vmware locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

chore Chore dependencies Dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants