Skip to content

fix: fusion 13 x86_x64 vmware tools location#138

Closed
Stromweld wants to merge 2 commits intovmware:mainfrom
Stromweld:patch-1
Closed

fix: fusion 13 x86_x64 vmware tools location#138
Stromweld wants to merge 2 commits intovmware:mainfrom
Stromweld:patch-1

Conversation

@Stromweld
Copy link
Copy Markdown
Contributor

Bug found in x86_64 directory as vmware fusion 13 has the vmware tools iso's in x86_x64 directory
Closes #137

@Stromweld Stromweld requested a review from a team as a code owner June 6, 2023 16:34
@Stromweld
Copy link
Copy Markdown
Contributor Author

I don't have a machine to test fusion 12 or less to verify if line 140 also needs updating.

@nywilken
Copy link
Copy Markdown
Contributor

I don't have a machine to test fusion 12 or less to verify if line 140 also needs updating.

@Stromweld apologies for the delayed response here. I've been traveling so just catching up. I have Fusion 12 and can confirm that we need some extra logic for fusion 12.

Channeling @tenthirtyam here, Fusion 12 is essentially unsupported as of March this year. Which seems to imply that maybe we should look to add the fusion driver or let Fusion 12 be for 1.0.8 and move to a new minor version for Fusion 13. Thoughts?

@Stromweld
Copy link
Copy Markdown
Contributor Author

If it's unsupported that would make sense to me to potentially drop support and simplify the driver. I'd think since that would be a breaking change for all those with fusion 12 and below that it would warrant a major version increment. 1.x would be for 12 and below, where 2.x would then be for 13+.

@Stromweld
Copy link
Copy Markdown
Contributor Author

Can we push this fix for x86 packer vmware builds and create an issue as a follow on to decide on what to do with fusion12 and earlier support?

@Stromweld
Copy link
Copy Markdown
Contributor Author

@tenthirtyam any update?

@tenthirtyam tenthirtyam changed the title bugfix for fusion 13 x86_x64 vmware tools location fix: fusion 13 x86_x64 vmware tools location Aug 15, 2023
@tenthirtyam tenthirtyam changed the title fix: fusion 13 x86_x64 vmware tools location fix: fusion 13 x86_x64 vmware tools location Aug 22, 2023
@tenthirtyam
Copy link
Copy Markdown
Collaborator

@nywilken @Stromweld - while it could be considered a "breaking change" I recommend the following:

  • Release v1.1.0 to address support for Fusion 13.x / Workstation 17.x and the change for the isoimages.
  • Previous versions, specifically v1.0.8 should be used for Fusion 12 / Workstation 16 which are no longer under general support.
  • Note in the CHANGELOG .mdand the GitHub release.
  • Collaborate and review the scope to invest in a cleanup of the codebase and rev to v2.x.x.

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@nywilken - This pull request can be superseded by #139.

@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vmware-iso: "Couldn't find VMware tools for 'linux'!"

3 participants