Add a set of working VMware Fusion examples#130
Merged
Conversation
tenthirtyam
reviewed
Apr 13, 2023
tenthirtyam
reviewed
Apr 13, 2023
tenthirtyam
reviewed
Apr 13, 2023
tenthirtyam
reviewed
Apr 13, 2023
tenthirtyam
reviewed
Apr 13, 2023
tenthirtyam
reviewed
Apr 13, 2023
Collaborator
There was a problem hiding this comment.
Might be nice to show how this can be done with a template like ks.pkrtpl.hcl.
An example I have authored for the vSphere plugin: https://github.com/vmware-samples/packer-examples-for-vsphere/blob/main/builds/linux/debian/11/data/ks.pkrtpl.hcl
Contributor
Author
There was a problem hiding this comment.
That is a good addition. I can roll that in. Thanks for the example.
tenthirtyam
requested changes
Apr 13, 2023
Collaborator
tenthirtyam
left a comment
There was a problem hiding this comment.
I've added some comments for consideration.
6a97865 to
7bf626f
Compare
* Create initial template bundle structure with pkrvar files * Add variable for memory * Update preseed configuration * Add adapter types to config * Add output directory for each build
* Update data directory for Fusion 12 example * Parametrized headless attribute for debugging * Remove deprecated preseed.cfg
df1026a to
295786f
Compare
* Add a usage section to the main README that links to the example directory. * Update text for Fusion 13 pkrvars.hcl file link
lbajolet-hashicorp
approved these changes
Apr 14, 2023
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Just left a little nit, but aside from that, LGTM!
Co-authored-by: Lucas Bajolet <105649352+lbajolet-hashicorp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a set of template examples for Fusion 13 and Fusion 12. These templates have been tested for both arm64 and x86_64 processors.
The source files are spread across multiple files:
Closes #108
Relates to: #131