Skip to content

chore(deps): bump golang.org/x/text from 0.28.0 to 0.31.0#3913

Merged
tenthirtyam merged 1 commit intomainfrom
chore(deps)/bump-x-text
Nov 27, 2025
Merged

chore(deps): bump golang.org/x/text from 0.28.0 to 0.31.0#3913
tenthirtyam merged 1 commit intomainfrom
chore(deps)/bump-x-text

Conversation

@tenthirtyam
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam commented Nov 25, 2025 •
edited
Loading

Description

Bumps golang.org/x/text from 0.28.0 to 0.31.0 which in turn updates the Go version requirement across the project to 1.24.

Dependency updates:

  • Bumped the golang.org/x/text dependency from v0.28.0 to v0.31.0 in all relevant go.mod files to incorporate bug fixes and improvements. [1] [2] [3]

Go version upgrades:

  • Updated the required Go version from 1.23.0 to 1.24.0 in go.mod, govc/go.mod, and vcsim/go.mod to leverage newer language features and maintain support. [1] [2] [3]
  • Updated the GitHub Actions workflows to use Go versions 1.24 and 1.25 for unit tests and 1.24 for other jobs, replacing older versions. [1] [2] [3]

Formatting and output improvements:

Addressed govet issues raised after the Go version update.

level=info msg="[runner/skip_dirs] Skipped 8 issues from dir vim25/json by pattern vim25/json"
Error: cli/dvs/portgroup/info.go:141:13: printf: non-constant format string in call to fmt.Printf (govet)
level=info msg="[runner/skip_dirs] Skipped 2 issues from dir vim25/xml by pattern vim25/xml"
level=info msg="[runner] Issues before processing: 51, after processing: 7"
level=info msg="[runner] Processors filtering stat (in/out): uniq_by_line: 7/7, max_from_linter: 7/7, path_prettifier: 7/7, filename_unadjuster: 51/51, path_relativity: 51/51, skip_dirs: 51/41, diff: 7/7, source_code: 7/7, cgo: 51/51, invalid_issue: 51/51, generated_file_filter: 41/41, identifier_marker: 41/41, exclusion_rules: 41/41, nolint_filter: 41/7, path_shortener: 7/7, severity-rules: 7/7, exclusion_paths: 51/51, max_per_file_from_linter: 7/7, max_same_issues: 7/7, sort_results: 7/7, path_absoluter: 51/51, skip_files: 51/51, fixer: 7/7"
level=info msg="[runner] processing took 7.823729ms with stages: nolint_filter: 6.05507ms, exclusion_rules: 1.220091ms, source_code: 176.439µs, generated_file_filter: 173.963µs, skip_dirs: 105.396µs, path_relativity: 45.073µs, identifier_marker: 23.694µs, invalid_issue: 4.328µs, uniq_by_line: 3.015µs, path_shortener: 2.895µs, cgo: 2.865µs, max_same_issues: 2.715µs, path_absoluter: 2.284µs, filename_unadjuster: 2.274µs, max_from_linter: 932ns, max_per_file_from_linter: 491ns, exclusion_paths: 420ns, fixer: 392ns, sort_results: 350ns, skip_files: 311ns, diff: 310ns, path_prettifier: 291ns, severity-rules: 130ns"
level=info msg="[runner] linters took 6.492012774s with stages: goanalysis_metalinter: 6.484099685s"
level=info msg="File cache stats: 5 entries of total size 156.3KiB"
level=info msg="Memory: 612 samples, avg is 88.8MB, max is 748.8MB"
level=info msg="Execution took 1m1.233081233s"
	fmt.Printf("+" + strings.Repeat("-", headLen) + "+\n")
	           ^
Error: cli/dvs/portgroup/info.go:162:13: printf: non-constant format string in call to fmt.Printf (govet)
	fmt.Printf("+" + strings.Repeat("-", headLen) + "+\n")
	           ^
Error: cli/dvs/portgroup/info.go:175:13: printf: non-constant format string in call to fmt.Printf (govet)
	fmt.Printf("+" + strings.Repeat("-", headLen) + "+\n")
	           ^
Error: cli/task/recent.go:303:17: printf: non-constant format string in call to fmt.Fprintf (govet)
	fmt.Fprintf(w, t.format("Task", "Target", "Initiator", "Queued", "Started", "Completed", "Result"))
	               ^
Error: list/lister.go:155:26: printf: non-constant format string in call to fmt.Errorf (govet)
		return nil, fmt.Errorf("cannot traverse type " + l.Reference.Type)
		                       ^
Error: simulator/container_virtual_machine.go:322:22: printf: non-constant format string in call to (*github.com/vmware/govmomi/simulator.VirtualMachine).logPrintf (govet)
				svm.vm.logPrintf(msg)
				                 ^
Error: simulator/virtual_machine_test.go:2945:44: printf: non-constant format string in call to github.com/vmware/govmomi/simulator.newInvalidStateFault (govet)
				Fault:            newInvalidStateFault(msg),
				                                       ^
make[1]: *** [Makefile:59: lint-go] Error 1
make[1]: Leaving directory '/home/runner/work/govmomi/govmomi'
make: *** [Makefile:54: lint] Error 2
  • Replaced fmt.Printf with fmt.Print for table border output in cli/dvs/portgroup/info.go to improve consistency. [1] [2] [3]
  • Changed header output in cli/task/recent.go from fmt.Fprintf to fmt.Fprint for writing to io.Writer.
  • Improved error message formatting in list/lister.go by using a format string instead of concatenation.
  • Standardized error creation in simulator/container_virtual_machine.go by replacing custom error construction with fmt.Errorf, and removed unnecessary import of errors. [1] [2]
  • Improved error message formatting in simulator/virtual_machine_test.go by using a format string for newInvalidStateFault.

Ref: #3902

@tenthirtyam tenthirtyam self-assigned this Nov 25, 2025
Copilot AI review requested due to automatic review settings November 25, 2025 21:36
@tenthirtyam tenthirtyam marked this pull request as draft November 25, 2025 21:37

This comment was marked as resolved.

Sign in to view

@tenthirtyam tenthirtyam force-pushed the chore(deps)/bump-x-text branch 2 times, most recently from be50c5d to d2b974e Compare November 25, 2025 21:58
@tenthirtyam tenthirtyam marked this pull request as ready for review November 25, 2025 22:05
@tenthirtyam
Copy link
Copy Markdown
Contributor Author

tenthirtyam commented Nov 26, 2025 •
edited
Loading

Looks like there is one more govet issue to fix that's causing the tests to fail.

@tenthirtyam tenthirtyam force-pushed the chore(deps)/bump-x-text branch 2 times, most recently from b6adafb to 2b29810 Compare November 26, 2025 17:39
dougm
dougm previously approved these changes Nov 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @tenthirtyam

spacegospod
spacegospod previously approved these changes Nov 27, 2025
View reviewed changes
@tenthirtyam tenthirtyam dismissed stale reviews from spacegospod and dougm via 91d278d November 27, 2025 15:42
@tenthirtyam tenthirtyam force-pushed the chore(deps)/bump-x-text branch from 2b29810 to 91d278d Compare November 27, 2025 15:42
@tenthirtyam
chore(deps): bump golang.org/x/text from 0.28.0 to 0.31.0
515fbad 
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.28.0 to 0.31.0.

Ref: #3902

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the chore(deps)/bump-x-text branch from 91d278d to 515fbad Compare November 27, 2025 15:46
@tenthirtyam tenthirtyam merged commit 4da134e into main Nov 27, 2025
11 checks passed
@tenthirtyam tenthirtyam deleted the chore(deps)/bump-x-text branch November 27, 2025 15:52
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@spacegospod spacegospod spacegospod approved these changes

@akutz akutz Awaiting requested review from akutz

@dougm dougm Awaiting requested review from dougm

Assignees

@tenthirtyam tenthirtyam

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tenthirtyam @dougm @spacegospod