Skip to content

feat: add bindings for enableOnZones and enableOnComputeCluster#3909

Merged
tenthirtyam merged 3 commits intovmware:mainfrom
spacegospod:feat/supervisor-enable
Nov 26, 2025
Merged

feat: add bindings for enableOnZones and enableOnComputeCluster#3909
tenthirtyam merged 3 commits intovmware:mainfrom
spacegospod:feat/supervisor-enable

Conversation

@spacegospod
Copy link
Copy Markdown
Collaborator

@spacegospod spacegospod commented Nov 21, 2025 •
edited
Loading

Description

Adding bindings for the following endpoints, structures included

https://developer.broadcom.com/xapis/vsphere-automation-api/latest/api/vcenter/namespace-management/supervisors__action=enable_on_zones/post/

https://developer.broadcom.com/xapis/vsphere-automation-api/latest/api/vcenter/namespace-management/supervisors/cluster__action=enable_on_compute_cluster/post/

Closes: #(issue-number)

How Has This Been Tested?

Used these bindings in a local deployment of vmware/terraform-provider-vsphere to trigger both APIs

Guidelines

Please read and follow the CONTRIBUTION guidelines of this project.

@spacegospod
feat: add bindings for enableOnZones and enableOnComputeCluster
8f02772 
Signed-off-by: Stoyan Zhelyazkov <stoyan.zhelyazkov@broadcom.com>
@spacegospod spacegospod requested a review from fstrudel November 21, 2025 14:04
@spacegospod spacegospod self-assigned this Nov 21, 2025
tenthirtyam
tenthirtyam previously approved these changes Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam requested a review from akutz November 21, 2025 15:01
@spacegospod
fix: make images and storage optional
a829b5f 
Signed-off-by: Stoyan Zhelyazkov <stoyan.zhelyazkov@broadcom.com>
@spacegospod
Copy link
Copy Markdown
Collaborator Author

spacegospod commented Nov 24, 2025

LGTM

Thanks, so far I've manually tested EnableOnComputeCluster and I had to correct the bindings with a829b5f7f56f8ce385fd36df0c03df73436a7467
I may have to make more corrections after testing EnableOnZones

@spacegospod
fix: pass a string pointer to client Do
7faf412 
Signed-off-by: Stoyan Zhelyazkov <stoyan.zhelyazkov@broadcom.com>
@spacegospod
Copy link
Copy Markdown
Collaborator Author

spacegospod commented Nov 25, 2025 •
edited
Loading

LGTM

Thanks, so far I've manually tested EnableOnComputeCluster and I had to correct the bindings with a829b5f7f56f8ce385fd36df0c03df73436a7467 I may have to make more corrections after testing EnableOnZones

Okay @tenthirtyam , I verified that EnableOnZones works too. I had to make 1 more fix to the bindings, they should be good-to-go now

tenthirtyam
tenthirtyam requested changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tenthirtyam tenthirtyam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacegospod - may I suggest updating comments for the existing EnableClusterSpec and SizingHint to align with the same developer.broadcom.com reference you included in this change? That might make this better - otherwise LGTM! 🚀

@spacegospod
Copy link
Copy Markdown
Collaborator Author

spacegospod commented Nov 26, 2025

@spacegospod - may I suggest updating comments for the existing EnableClusterSpec and SizingHint to align with the same developer.broadcom.com reference you included in this change? That might make this better - otherwise LGTM! 🚀

That's a good idea but there are 42 references to "vmware.com" in namespace.go alone, it doesn't end with EnableClusterSpec and SizingHint.
The URLs on the new developer portal are not a 1-to-1 mapping of the ones that used to be on vmware.com. What I mean to say is that each URL needs to be handled manually and I really want to avoid that

@tenthirtyam tenthirtyam merged commit 0585640 into vmware:main Nov 26, 2025
13 of 14 checks passed
@spacegospod spacegospod mentioned this pull request Dec 4, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@fstrudel fstrudel Awaiting requested review from fstrudel

@akutz akutz Awaiting requested review from akutz

Assignees

@spacegospod spacegospod

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spacegospod @tenthirtyam