refactor: update NumCoresPerSocket to *int32#3906
Merged
tenthirtyam merged 2 commits intovmware:mainfrom Nov 25, 2025
Merged
Conversation
Signed-off-by: Stoyan Zhelyazkov <stoyan.zhelyazkov@broadcom.com>
1adecde to
7a189fa
Compare
Signed-off-by: Stoyan Zhelyazkov <stoyan.zhelyazkov@broadcom.com>
tenthirtyam
approved these changes
Nov 20, 2025
NumCoresPerSocket to *int32
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NumCoresPerSocketontypes.VirtualMachineConfigSpecis anint32and annotated with "omitempty"This makes it impossible to pass 0 when calling
ReconfigVMandCreateVM.To remediate this I am changing the field to an
*int32. Now its zero value will be nil and 0 will be serialized along with the rest of the structure.Closes: N/A
How Has This Been Tested?
Configured a local override for
vmware/govmomiinvmware/terraform-provider-vsphereand ran tests which create and reconfigure virtual machines.I verified that nil, 0 and any positive integer (if valid for that VM) is accepted by vCenter
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.